Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Side by Side Diff: runtime/vm/intermediate_language_arm.cc

Issue 2975913002: Temporarily back out newly introduced assertions to fix buildbots (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | runtime/vm/intermediate_language_x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM.
6 #if defined(TARGET_ARCH_ARM) 6 #if defined(TARGET_ARCH_ARM)
7 7
8 #include "vm/intermediate_language.h" 8 #include "vm/intermediate_language.h"
9 9
10 #include "vm/compiler.h" 10 #include "vm/compiler.h"
(...skipping 6528 matching lines...) Expand 10 before | Expand all | Expand 10 after
6539 6539
6540 Label* deopt = NULL; 6540 Label* deopt = NULL;
6541 if (CanDeoptimize()) { 6541 if (CanDeoptimize()) {
6542 deopt = compiler->AddDeoptStub(deopt_id(), ICData::kDeoptBinaryMintOp); 6542 deopt = compiler->AddDeoptStub(deopt_id(), ICData::kDeoptBinaryMintOp);
6543 } 6543 }
6544 if (locs()->in(1).IsConstant()) { 6544 if (locs()->in(1).IsConstant()) {
6545 // Code for a constant shift amount. 6545 // Code for a constant shift amount.
6546 ASSERT(locs()->in(1).constant().IsSmi()); 6546 ASSERT(locs()->in(1).constant().IsSmi());
6547 const int32_t shift = 6547 const int32_t shift =
6548 reinterpret_cast<int32_t>(locs()->in(1).constant().raw()) >> 1; 6548 reinterpret_cast<int32_t>(locs()->in(1).constant().raw()) >> 1;
6549 ASSERT(!has_shift_count_check()); 6549 // TODO(alexmarkov): revise and uncomment the following assertions
6550 ASSERT(shift >= 0); 6550 // ASSERT(!has_shift_count_check());
6551 // ASSERT(shift >= 0);
6551 switch (op_kind()) { 6552 switch (op_kind()) {
6552 case Token::kSHR: { 6553 case Token::kSHR: {
6553 if (shift < 32) { 6554 if (shift < 32) {
6554 __ Lsl(out_lo, left_hi, Operand(32 - shift)); 6555 __ Lsl(out_lo, left_hi, Operand(32 - shift));
6555 __ orr(out_lo, out_lo, Operand(left_lo, LSR, shift)); 6556 __ orr(out_lo, out_lo, Operand(left_lo, LSR, shift));
6556 __ Asr(out_hi, left_hi, Operand(shift)); 6557 __ Asr(out_hi, left_hi, Operand(shift));
6557 } else { 6558 } else {
6558 if (shift == 32) { 6559 if (shift == 32) {
6559 __ mov(out_lo, Operand(left_hi)); 6560 __ mov(out_lo, Operand(left_hi));
6560 } else if (shift < 64) { 6561 } else if (shift < 64) {
(...skipping 590 matching lines...) Expand 10 before | Expand all | Expand 10 after
7151 ASSERT(!compiler->is_optimizing()); 7152 ASSERT(!compiler->is_optimizing());
7152 __ BranchLinkPatchable(*StubCode::DebugStepCheck_entry()); 7153 __ BranchLinkPatchable(*StubCode::DebugStepCheck_entry());
7153 compiler->AddCurrentDescriptor(stub_kind_, deopt_id_, token_pos()); 7154 compiler->AddCurrentDescriptor(stub_kind_, deopt_id_, token_pos());
7154 compiler->RecordSafepoint(locs()); 7155 compiler->RecordSafepoint(locs());
7155 } 7156 }
7156 7157
7157 7158
7158 } // namespace dart 7159 } // namespace dart
7159 7160
7160 #endif // defined TARGET_ARCH_ARM 7161 #endif // defined TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | runtime/vm/intermediate_language_x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698