Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Side by Side Diff: runtime/vm/intermediate_language_x64.cc

Issue 2975913002: Temporarily back out newly introduced assertions to fix buildbots (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/intermediate_language_arm.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_X64. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_X64.
6 #if defined(TARGET_ARCH_X64) 6 #if defined(TARGET_ARCH_X64)
7 7
8 #include "vm/intermediate_language.h" 8 #include "vm/intermediate_language.h"
9 9
10 #include "vm/compiler.h" 10 #include "vm/compiler.h"
(...skipping 6054 matching lines...) Expand 10 before | Expand all | Expand 10 after
6065 6065
6066 Label* deopt = NULL; 6066 Label* deopt = NULL;
6067 if (CanDeoptimize()) { 6067 if (CanDeoptimize()) {
6068 deopt = compiler->AddDeoptStub(deopt_id(), ICData::kDeoptBinaryMintOp); 6068 deopt = compiler->AddDeoptStub(deopt_id(), ICData::kDeoptBinaryMintOp);
6069 } 6069 }
6070 if (locs()->in(1).IsConstant()) { 6070 if (locs()->in(1).IsConstant()) {
6071 // Code for a constant shift amount. 6071 // Code for a constant shift amount.
6072 ASSERT(locs()->in(1).constant().IsSmi()); 6072 ASSERT(locs()->in(1).constant().IsSmi());
6073 const int64_t shift = 6073 const int64_t shift =
6074 reinterpret_cast<int64_t>(locs()->in(1).constant().raw()) >> 1; 6074 reinterpret_cast<int64_t>(locs()->in(1).constant().raw()) >> 1;
6075 ASSERT(!has_shift_count_check()); 6075 // TODO(alexmarkov): revise and uncomment the following assertions
6076 ASSERT((0 <= shift) && (shift < 64)); 6076 // ASSERT(!has_shift_count_check());
6077 // ASSERT((0 <= shift) && (shift < 64));
6077 switch (op_kind()) { 6078 switch (op_kind()) {
6078 case Token::kSHR: 6079 case Token::kSHR:
6079 __ sarq(left, Immediate(shift)); 6080 __ sarq(left, Immediate(shift));
6080 break; 6081 break;
6081 case Token::kSHL: { 6082 case Token::kSHL: {
6082 if (can_overflow()) { 6083 if (can_overflow()) {
6083 // Check for overflow. 6084 // Check for overflow.
6084 Register temp = locs()->temp(0).reg(); 6085 Register temp = locs()->temp(0).reg();
6085 __ movq(temp, left); 6086 __ movq(temp, left);
6086 __ shlq(left, Immediate(shift)); 6087 __ shlq(left, Immediate(shift));
(...skipping 561 matching lines...) Expand 10 before | Expand all | Expand 10 after
6648 compiler->AddCurrentDescriptor(stub_kind_, deopt_id_, token_pos()); 6649 compiler->AddCurrentDescriptor(stub_kind_, deopt_id_, token_pos());
6649 compiler->RecordSafepoint(locs()); 6650 compiler->RecordSafepoint(locs());
6650 } 6651 }
6651 6652
6652 6653
6653 } // namespace dart 6654 } // namespace dart
6654 6655
6655 #undef __ 6656 #undef __
6656 6657
6657 #endif // defined TARGET_ARCH_X64 6658 #endif // defined TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « runtime/vm/intermediate_language_arm.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698