Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(284)

Issue 2975413002: Move ia2_attributes handling to AXPlatformNodeWin. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 1 week ago by dougt
Modified:
2 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, aboxhall+watch_chromium.org, nektar+watch_chromium.org, jam, yuzo+watch_chromium.org, dougt+watch_chromium.org, darin-cc_chromium.org, aleventhal+watch_chromium.org, dtseng+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move ia2_attributes handling to AXPlatformNodeWin. BUG=703369 Review-Url: https://codereview.chromium.org/2975413002 Cr-Commit-Position: refs/heads/master@{#487194} Committed: https://chromium.googlesource.com/chromium/src/+/264fce039d83d045fdaf2d613f72c435aa81d225

Patch Set 1 : Initial #

Total comments: 4

Patch Set 2 : Suggestions from dmazzoni #

Unified diffs Side-by-side diffs Delta from patch set Stats (+319 lines, -301 lines) Patch
M content/browser/accessibility/browser_accessibility_com_win.h View 3 chunks +0 lines, -23 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_com_win.cc View 1 6 chunks +11 lines, -271 lines 0 comments Download
M ui/accessibility/platform/ax_platform_node_base.h View 1 chunk +5 lines, -0 lines 0 comments Download
M ui/accessibility/platform/ax_platform_node_base.cc View 2 chunks +11 lines, -0 lines 0 comments Download
M ui/accessibility/platform/ax_platform_node_win.h View 1 2 chunks +30 lines, -2 lines 0 comments Download
M ui/accessibility/platform/ax_platform_node_win.cc View 1 6 chunks +262 lines, -5 lines 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 23 (18 generated)
dougt
hi dmazzoni, ptal.
2 months, 1 week ago (2017-07-17 02:34:52 UTC) #11
dmazzoni
lgtm https://codereview.chromium.org/2975413002/diff/20001/ui/accessibility/platform/ax_platform_node_win.cc File ui/accessibility/platform/ax_platform_node_win.cc (right): https://codereview.chromium.org/2975413002/diff/20001/ui/accessibility/platform/ax_platform_node_win.cc#newcode2473 ui/accessibility/platform/ax_platform_node_win.cc:2473: ia2_attributes_.clear(); It doesn't seem to make sense to ...
2 months ago (2017-07-17 08:27:18 UTC) #12
dougt
https://codereview.chromium.org/2975413002/diff/20001/ui/accessibility/platform/ax_platform_node_win.cc File ui/accessibility/platform/ax_platform_node_win.cc (right): https://codereview.chromium.org/2975413002/diff/20001/ui/accessibility/platform/ax_platform_node_win.cc#newcode2473 ui/accessibility/platform/ax_platform_node_win.cc:2473: ia2_attributes_.clear(); On 2017/07/17 08:27:18, dmazzoni wrote: > It doesn't ...
2 months ago (2017-07-17 19:28:27 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2975413002/40001
2 months ago (2017-07-17 19:28:45 UTC) #20
commit-bot: I haz the power
2 months ago (2017-07-17 19:36:15 UTC) #23
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/264fce039d83d045fdaf2d613f72...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld b40b6558b