Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 2975013002: Make chromeos CUPS printing code namespaces consistent. (Closed)

Created:
3 years, 5 months ago by Carlson
Modified:
3 years, 5 months ago
Reviewers:
Lei Zhang, skau
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make chromeos CUPS printing code namespaces consistent. Previously printing code was in a mix of chromeos:: and chromeos::printing. This standardizes everything on chromeos::, removing the chromeos::printing namespace completely. These changes are almost entirely mechanical. I did rename the factory function "CreateProvider" to the less generic "CreatePpdProvider" since it's now in ::chromeos directly. BUG=702710 Review-Url: https://codereview.chromium.org/2975013002 Cr-Commit-Position: refs/heads/master@{#487334} Committed: https://chromium.googlesource.com/chromium/src/+/5c3feaef653f0f612759f9fb7fc35d1f67a8cbf7

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -91 lines) Patch
M chrome/browser/chromeos/printing/ppd_provider_factory.h View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/printing/ppd_provider_factory.cc View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/chromeos/printing/printer_configurer.cc View 1 5 chunks +11 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/printing/specifics_translation.h View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/printing/specifics_translation.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/printing/specifics_translation_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/printing/synced_printers_manager.cc View 1 6 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/printing/synced_printers_manager_unittest.cc View 1 6 chunks +16 lines, -16 lines 0 comments Download
M chrome/browser/chromeos/printing/usb_printer_detector.cc View 1 2 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/printer_backend_proxy_chromeos.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.h View 3 chunks +8 lines, -12 lines 0 comments Download
M chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc View 1 2 chunks +7 lines, -7 lines 0 comments Download
M chromeos/printing/ppd_cache.h View 2 chunks +0 lines, -2 lines 0 comments Download
M chromeos/printing/ppd_cache.cc View 1 2 chunks +0 lines, -2 lines 0 comments Download
M chromeos/printing/ppd_cache_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chromeos/printing/ppd_provider.h View 2 chunks +0 lines, -2 lines 0 comments Download
M chromeos/printing/ppd_provider.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chromeos/printing/ppd_provider_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chromeos/printing/printer_translator.h View 2 chunks +0 lines, -2 lines 0 comments Download
M chromeos/printing/printer_translator.cc View 3 chunks +1 line, -4 lines 0 comments Download
M chromeos/printing/printer_translator_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chromeos/printing/printing_constants.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (12 generated)
Carlson
thestig@ can you look over the stuff in chrome/browser/ui/webui? skau@: can you look over everything ...
3 years, 5 months ago (2017-07-12 18:20:53 UTC) #7
Lei Zhang
On 2017/07/12 18:20:53, Carlson wrote: > thestig@ can you look over the stuff in chrome/browser/ui/webui? ...
3 years, 5 months ago (2017-07-12 21:28:32 UTC) #8
skau
lgtm
3 years, 5 months ago (2017-07-17 19:46:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2975013002/1
3 years, 5 months ago (2017-07-17 23:57:20 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clang_dbg_recipe/builds/311405) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
3 years, 5 months ago (2017-07-18 00:04:12 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2975013002/20001
3 years, 5 months ago (2017-07-18 00:47:24 UTC) #16
commit-bot: I haz the power
3 years, 5 months ago (2017-07-18 01:43:15 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5c3feaef653f0f612759f9fb7fc3...

Powered by Google App Engine
This is Rietveld 408576698