Make chromeos CUPS printing code namespaces consistent.

chrome/browser/chromeos/printing/synced_printers_manager_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/printing/synced_printers_manager.h"
 
 #include <memory>
 #include <utility>
 
 #include "base/bind.h"
 #include "base/debug/dump_without_crashing.h"
 #include "base/memory/ptr_util.h"
 #include "base/optional.h"
 #include "base/run_loop.h"
 #include "base/time/time.h"
 #include "chrome/browser/chromeos/printing/printers_sync_bridge.h"
 #include "chrome/browser/chromeos/printing/synced_printers_manager_factory.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/test/base/testing_profile.h"
 #include "components/sync/model/fake_model_type_change_processor.h"
 #include "components/sync/model/model_type_store.h"
 #include "components/sync_preferences/testing_pref_service_syncable.h"
 #include "content/public/test/test_browser_thread_bundle.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace chromeos {
 
 namespace {
 
-const char kPrinterId[] = "UUID-UUID-UUID-PRINTER";
-const char kUri[] = "ipps://printer.chromium.org/ipp/print";
+const char kTestPrinterId[] = "UUID-UUID-UUID-PRINTER";
+const char kTestUri[] = "ipps://printer.chromium.org/ipp/print";
 
 const char kLexJson[] = R"json({
         "display_name": "LexaPrint",
         "description": "Laser on the test shelf",
         "manufacturer": "LexaPrint, Inc.",
         "model": "MS610de",
         "uri": "ipp://192.168.1.5",
         "ppd_resource": {
           "effective_manufacturer": "LexaPrint",
           "effective_model": "MS610de",
@@ skipping 60 matching lines @@
 
   // Must outlive |manager_|.
   TestingProfile profile_;
 
   SyncedPrintersManager manager_;
 };
 
 TEST_F(SyncedPrintersManagerTest, AddPrinter) {
   LoggingObserver observer;
   manager_.AddObserver(&observer);
-  manager_.RegisterPrinter(base::MakeUnique<Printer>(kPrinterId));
+  manager_.RegisterPrinter(base::MakeUnique<Printer>(kTestPrinterId));
 
   auto printers = manager_.GetPrinters();
   ASSERT_EQ(1U, printers.size());
-  EXPECT_EQ(kPrinterId, printers[0]->id());
+  EXPECT_EQ(kTestPrinterId, printers[0]->id());
   EXPECT_EQ(Printer::Source::SRC_USER_PREFS, printers[0]->source());
 
   EXPECT_TRUE(observer.AddCalled());
   EXPECT_FALSE(observer.UpdateCalled());
 }
 
 TEST_F(SyncedPrintersManagerTest, UpdatePrinterAssignsId) {
   manager_.RegisterPrinter(base::MakeUnique<Printer>());
 
   auto printers = manager_.GetPrinters();
   ASSERT_EQ(1U, printers.size());
   EXPECT_FALSE(printers[0]->id().empty());
 }
 
 TEST_F(SyncedPrintersManagerTest, UpdatePrinter) {
-  manager_.RegisterPrinter(base::MakeUnique<Printer>(kPrinterId));
-  auto updated_printer = base::MakeUnique<Printer>(kPrinterId);
-  updated_printer->set_uri(kUri);
+  manager_.RegisterPrinter(base::MakeUnique<Printer>(kTestPrinterId));
+  auto updated_printer = base::MakeUnique<Printer>(kTestPrinterId);
+  updated_printer->set_uri(kTestUri);
 
   // Register observer so it only receives the update event.
   LoggingObserver observer;
   manager_.AddObserver(&observer);
 
   manager_.RegisterPrinter(std::move(updated_printer));
 
   auto printers = manager_.GetPrinters();
   ASSERT_EQ(1U, printers.size());
-  EXPECT_EQ(kUri, printers[0]->uri());
+  EXPECT_EQ(kTestUri, printers[0]->uri());
 
   EXPECT_TRUE(observer.UpdateCalled());
   EXPECT_FALSE(observer.AddCalled());
 }
 
 TEST_F(SyncedPrintersManagerTest, RemovePrinter) {
   manager_.RegisterPrinter(base::MakeUnique<Printer>("OtherUUID"));
-  manager_.RegisterPrinter(base::MakeUnique<Printer>(kPrinterId));
+  manager_.RegisterPrinter(base::MakeUnique<Printer>(kTestPrinterId));
   manager_.RegisterPrinter(base::MakeUnique<Printer>());
 
-  manager_.RemovePrinter(kPrinterId);
+  manager_.RemovePrinter(kTestPrinterId);
 
   auto printers = manager_.GetPrinters();
   ASSERT_EQ(2U, printers.size());
-  EXPECT_NE(kPrinterId, printers.at(0)->id());
-  EXPECT_NE(kPrinterId, printers.at(1)->id());
+  EXPECT_NE(kTestPrinterId, printers.at(0)->id());
+  EXPECT_NE(kTestPrinterId, printers.at(1)->id());
 }
 
 // Tests for policy printers
 
 TEST_F(SyncedPrintersManagerTest, RecommendedPrinters) {
   std::string first_printer =
       R"json({
       "display_name": "Color Laser",
       "description": "The printer next to the water cooler.",
       "manufacturer": "Printer Manufacturer",
@@ skipping 38 matching lines @@
 
   const Printer& from_list = *(printers.front());
   std::unique_ptr<Printer> retrieved = manager_.GetPrinter(from_list.id());
 
   EXPECT_EQ(from_list.id(), retrieved->id());
   EXPECT_EQ("LexaPrint", from_list.display_name());
   EXPECT_EQ(Printer::Source::SRC_POLICY, from_list.source());
 }
 
 TEST_F(SyncedPrintersManagerTest, PrinterNotInstalled) {
-  Printer printer(kPrinterId, base::Time::FromInternalValue(1000));
+  Printer printer(kTestPrinterId, base::Time::FromInternalValue(1000));
   EXPECT_FALSE(manager_.IsConfigurationCurrent(printer));
 }
 
 TEST_F(SyncedPrintersManagerTest, PrinterIsInstalled) {
-  Printer printer(kPrinterId, base::Time::FromInternalValue(1000));
+  Printer printer(kTestPrinterId, base::Time::FromInternalValue(1000));
   manager_.PrinterInstalled(printer);
   EXPECT_TRUE(manager_.IsConfigurationCurrent(printer));
 }
 
 TEST_F(SyncedPrintersManagerTest, UpdatedPrinterConfiguration) {
-  Printer printer(kPrinterId, base::Time::FromInternalValue(1000));
+  Printer printer(kTestPrinterId, base::Time::FromInternalValue(1000));
   manager_.PrinterInstalled(printer);
 
-  Printer updated_printer(kPrinterId, base::Time::FromInternalValue(2000));
+  Printer updated_printer(kTestPrinterId, base::Time::FromInternalValue(2000));
   EXPECT_FALSE(manager_.IsConfigurationCurrent(updated_printer));
 }
 
 }  // namespace chromeos