Description was changed from ========== Revert "Revert of Polymer: Remove unused paper-dialog and paper-dialog-behavior. (patchset ...
3 years, 5 months ago
(2017-07-06 16:49:14 UTC)
#1
Description was changed from
==========
Revert "Revert of Polymer: Remove unused paper-dialog and paper-dialog-behavior.
(patchset #1 id:1 of https://codereview.chromium.org/2963213002/ )"
This reverts commit 7b449e1b8f24470071fc6d07df3f42e0d914a484.
The last usage of paper-dialog has been removed at crrev.com/2966163003.
BUG=720781
==========
to
==========
Revert "Revert of Polymer: Remove unused paper-dialog and paper-dialog-behavior.
(patchset #1 id:1 of https://codereview.chromium.org/2963213002/ )"
This reverts commit 7b449e1b8f24470071fc6d07df3f42e0d914a484.
The last usage of paper-dialog has been removed at crrev.com/2966163003.
BUG=720781
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========
dpapad
The CQ bit was checked by dpapad@chromium.org to run a CQ dry run
3 years, 5 months ago
(2017-07-06 16:49:19 UTC)
#2
Description was changed from ========== Revert "Revert of Polymer: Remove unused paper-dialog and paper-dialog-behavior. (patchset ...
3 years, 5 months ago
(2017-07-06 16:51:00 UTC)
#4
Description was changed from
==========
Revert "Revert of Polymer: Remove unused paper-dialog and paper-dialog-behavior.
(patchset #1 id:1 of https://codereview.chromium.org/2963213002/ )"
This reverts commit 7b449e1b8f24470071fc6d07df3f42e0d914a484.
The last usage of paper-dialog has been removed at crrev.com/2966163003.
BUG=720781
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========
to
==========
Revert "Revert of Polymer: Remove unused paper-dialog and paper-dialog-behavior.
(patchset #1 id:1 of https://codereview.chromium.org/2963213002/ )"
This reverts commit 7b449e1b8f24470071fc6d07df3f42e0d914a484. Effectively this
is a relanding of crrev.com/2963213002.
The last usage of paper-dialog has been removed at crrev.com/2966163003.
BUG=720781
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========
dpapad
Description was changed from ========== Revert "Revert of Polymer: Remove unused paper-dialog and paper-dialog-behavior. (patchset ...
3 years, 5 months ago
(2017-07-06 16:51:29 UTC)
#5
Description was changed from
==========
Revert "Revert of Polymer: Remove unused paper-dialog and paper-dialog-behavior.
(patchset #1 id:1 of https://codereview.chromium.org/2963213002/ )"
This reverts commit 7b449e1b8f24470071fc6d07df3f42e0d914a484. Effectively this
is a relanding of crrev.com/2963213002.
The last usage of paper-dialog has been removed at crrev.com/2966163003.
BUG=720781
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========
to
==========
Revert "Revert of Polymer: Remove unused paper-dialog and paper-dialog-behavior.
(patchset #1 id:1 of https://codereview.chromium.org/2963213002/ )"
This reverts commit 7b449e1b8f24470071fc6d07df3f42e0d914a484. Effectively this
is a relanding of crrev.com/2963213002.
The last usage of paper-dialog has been removed at crrev.com/2966163003.
TBR=michaelpg@chromium.org
BUG=720781
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========
3 years, 5 months ago
(2017-07-06 17:28:56 UTC)
#7
dpapad
Description was changed from ========== Revert "Revert of Polymer: Remove unused paper-dialog and paper-dialog-behavior. (patchset ...
3 years, 5 months ago
(2017-07-06 17:29:19 UTC)
#8
Description was changed from
==========
Revert "Revert of Polymer: Remove unused paper-dialog and paper-dialog-behavior.
(patchset #1 id:1 of https://codereview.chromium.org/2963213002/ )"
This reverts commit 7b449e1b8f24470071fc6d07df3f42e0d914a484. Effectively this
is a relanding of crrev.com/2963213002.
The last usage of paper-dialog has been removed at crrev.com/2966163003.
TBR=michaelpg@chromium.org
BUG=720781
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========
to
==========
Revert "Revert of Polymer: Remove unused paper-dialog and
paper-dialog-behavior."
This reverts commit 7b449e1b8f24470071fc6d07df3f42e0d914a484. Effectively this
is a relanding of crrev.com/2963213002.
The last usage of paper-dialog has been removed at crrev.com/2966163003.
TBR=michaelpg@chromium.org
BUG=720781
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========
michaelpg
lgtm... wonder why file manager's use didn't show up in code search (i looked myself ...
3 years, 5 months ago
(2017-07-06 18:11:23 UTC)
#9
lgtm... wonder why file manager's use didn't show up in code search (i looked
myself when i reviewed the original CL)
dpapad
On 2017/07/06 at 18:11:23, michaelpg wrote: > lgtm... wonder why file manager's use didn't show ...
3 years, 5 months ago
(2017-07-06 18:19:12 UTC)
#10
On 2017/07/06 at 18:11:23, michaelpg wrote:
> lgtm... wonder why file manager's use didn't show up in code search (i looked
myself when i reviewed the original CL)
I think it was added very recently (while this CL was in progress).
Unfortunately we don't have a good automated way of declaring a Polymer element
as deprecated to prevent new usages of it. We could do this with paper-item (and
probably a few more).
dpapad
The CQ bit was unchecked by dpapad@chromium.org
3 years, 5 months ago
(2017-07-06 18:22:04 UTC)
#11
CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1499365325608750, "parent_rev": "799b4a3caeaaa5b99fea35d3ce3a96f7553b8f56", "commit_rev": "76c95498153b952fa28fd3a1d7759f7c006529f3"}
3 years, 5 months ago
(2017-07-06 18:25:27 UTC)
#14
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1499365325608750, "parent_rev":
"799b4a3caeaaa5b99fea35d3ce3a96f7553b8f56", "commit_rev":
"76c95498153b952fa28fd3a1d7759f7c006529f3"}
commit-bot: I haz the power
Description was changed from ========== Revert "Revert of Polymer: Remove unused paper-dialog and paper-dialog-behavior." This ...
3 years, 5 months ago
(2017-07-06 18:25:44 UTC)
#15
Message was sent while issue was closed.
Description was changed from
==========
Revert "Revert of Polymer: Remove unused paper-dialog and
paper-dialog-behavior."
This reverts commit 7b449e1b8f24470071fc6d07df3f42e0d914a484. Effectively this
is a relanding of crrev.com/2963213002.
The last usage of paper-dialog has been removed at crrev.com/2966163003.
TBR=michaelpg@chromium.org
BUG=720781
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========
to
==========
Revert "Revert of Polymer: Remove unused paper-dialog and
paper-dialog-behavior."
This reverts commit 7b449e1b8f24470071fc6d07df3f42e0d914a484. Effectively this
is a relanding of crrev.com/2963213002.
The last usage of paper-dialog has been removed at crrev.com/2966163003.
TBR=michaelpg@chromium.org
BUG=720781
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2974473002
Cr-Commit-Position: refs/heads/master@{#484679}
Committed:
https://chromium.googlesource.com/chromium/src/+/76c95498153b952fa28fd3a1d775...
==========
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/76c95498153b952fa28fd3a1d7759f7c006529f3
3 years, 5 months ago
(2017-07-06 18:25:46 UTC)
#16
Issue 2974473002: Revert "Revert of Polymer: Remove unused paper-dialog and paper-dialog-behavior.
(Closed)
Created 3 years, 5 months ago by dpapad
Modified 3 years, 5 months ago
Reviewers: michaelpg
Base URL:
Comments: 0