Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(745)

Issue 2974473002: Revert "Revert of Polymer: Remove unused paper-dialog and paper-dialog-behavior. (Closed)

Created:
3 years, 5 months ago by dpapad
Modified:
3 years, 5 months ago
Reviewers:
michaelpg
CC:
chromium-reviews, michaelpg+watch-polymer_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Revert of Polymer: Remove unused paper-dialog and paper-dialog-behavior." This reverts commit 7b449e1b8f24470071fc6d07df3f42e0d914a484. Effectively this is a relanding of crrev.com/2963213002. The last usage of paper-dialog has been removed at crrev.com/2966163003. TBR=michaelpg@chromium.org BUG=720781 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2974473002 Cr-Commit-Position: refs/heads/master@{#484679} Committed: https://chromium.googlesource.com/chromium/src/+/76c95498153b952fa28fd3a1d7759f7c006529f3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -534 lines) Patch
M third_party/polymer/v1_0/bower.json View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/paper-dialog-behavior/bower.json View 1 chunk +0 lines, -40 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/paper-dialog-behavior/compiled_resources2.gyp View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/paper-dialog-behavior/paper-dialog-behavior.html View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/paper-dialog-behavior/paper-dialog-behavior-extracted.js View 1 chunk +0 lines, -123 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/paper-dialog-behavior/paper-dialog-common.css View 1 chunk +0 lines, -57 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/paper-dialog-behavior/paper-dialog-shared-styles.html View 1 chunk +0 lines, -83 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/paper-dialog/bower.json View 1 chunk +0 lines, -40 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/paper-dialog/compiled_resources2.gyp View 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/paper-dialog/paper-dialog.html View 1 chunk +0 lines, -76 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/paper-dialog/paper-dialog-extracted.js View 1 chunk +0 lines, -36 lines 0 comments Download
M third_party/polymer/v1_0/components_summary.txt View 1 chunk +0 lines, -12 lines 0 comments Download
M ui/webui/resources/polymer_resources.grdp View 1 chunk +0 lines, -20 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
dpapad
3 years, 5 months ago (2017-07-06 17:28:56 UTC) #7
michaelpg
lgtm... wonder why file manager's use didn't show up in code search (i looked myself ...
3 years, 5 months ago (2017-07-06 18:11:23 UTC) #9
dpapad
On 2017/07/06 at 18:11:23, michaelpg wrote: > lgtm... wonder why file manager's use didn't show ...
3 years, 5 months ago (2017-07-06 18:19:12 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2974473002/1
3 years, 5 months ago (2017-07-06 18:22:10 UTC) #13
commit-bot: I haz the power
3 years, 5 months ago (2017-07-06 18:25:46 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/76c95498153b952fa28fd3a1d775...

Powered by Google App Engine
This is Rietveld 408576698