Simplify CookieMonster::SetAllCookies{,Async}() implementation.

Simplify CookieMonster::SetAllCookies{,Async}() implementation.

Given that for now the call must remain present but the precise semantics
of the call aren't important (see
https://codereview.chromium.org/2882063002/#msg64), it's worthwhile having
as clean and simple an implementation of reasonable semantics as possible.

BUG=None
R=mmenke@chromium.org

Review-Url: https://codereview.chromium.org/2974363002
Cr-Commit-Position: refs/heads/master@{#486248}
Committed: https://chromium.googlesource.com/chromium/src/+/0e84cea67c8d24ab6a8d7cb1efdf5ec467c6dc38

[Randy Smith (Not in Mondays), 2017-07-12 13:46:30]

The CQ bit was checked by rdsmith@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-12 13:46:42]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-12 13:54:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-12 13:54:54]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Randy Smith (Not in Mondays), 2017-07-12 15:02:08]

The CQ bit was checked by rdsmith@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-12 15:02:17]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mmenke, 2017-07-12 18:28:58]

Is this ready for review?

[Randy Smith (Not in Mondays), 2017-07-12 18:49:17]

On 2017/07/12 18:28:58, mmenke wrote:
> Is this ready for review?

Yes.  (Basically clean try jobs in PS 3.)

[mmenke, 2017-07-12 18:56:35]

Oops, guess this addresses one of my comments on the other CL.

https://codereview.chromium.org/2974363002/diff/60001/net/cookies/cookie_mons...
File net/cookies/cookie_monster.cc (left):

https://codereview.chromium.org/2974363002/diff/60001/net/cookies/cookie_mons...
net/cookies/cookie_monster.cc:1499: ComputeCookieDiff(&old_cookies, &list,
&positive_diff, &negative_diff);
Is ComputeCookieDiff still used?  I'd check it myself, but cs and cs-staging
both have borked indices.  We clearly need cs-as-it-was-2-days-ago.

https://codereview.chromium.org/2974363002/diff/60001/net/cookies/cookie_mons...
File net/cookies/cookie_monster.cc (right):

https://codereview.chromium.org/2974363002/diff/60001/net/cookies/cookie_mons...
net/cookies/cookie_monster.cc:1494: next_it != cookies_.end(); prev_it =
next_it) {
I think this can just be:

while (!cookies_.empty()) {
  InternalDeleteCookie(cookies_.begin(),....);
}

[mmenke, 2017-07-12 18:56:49]

Oh, and LGTM, modulo comments.

[Randy Smith (Not in Mondays), 2017-07-12 19:05:22]

The CQ bit was checked by rdsmith@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-12 19:05:56]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-12 19:11:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-12 19:11:48]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)

[Randy Smith (Not in Mondays), 2017-07-12 19:23:32]

The CQ bit was checked by rdsmith@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-12 19:23:54]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Randy Smith (Not in Mondays), 2017-07-12 20:07:08]

Thanks!

https://codereview.chromium.org/2974363002/diff/60001/net/cookies/cookie_mons...
File net/cookies/cookie_monster.cc (left):

https://codereview.chromium.org/2974363002/diff/60001/net/cookies/cookie_mons...
net/cookies/cookie_monster.cc:1499: ComputeCookieDiff(&old_cookies, &list,
&positive_diff, &negative_diff);
On 2017/07/12 18:56:35, mmenke wrote:
> Is ComputeCookieDiff still used?  I'd check it myself, but cs and cs-staging
> both have borked indices.  We clearly need cs-as-it-was-2-days-ago.

Used by test code in order to test it, which I think can be nuked.  Removed.

https://codereview.chromium.org/2974363002/diff/60001/net/cookies/cookie_mons...
File net/cookies/cookie_monster.cc (right):

https://codereview.chromium.org/2974363002/diff/60001/net/cookies/cookie_mons...
net/cookies/cookie_monster.cc:1494: next_it != cookies_.end(); prev_it =
next_it) {
On 2017/07/12 18:56:35, mmenke wrote:
> I think this can just be:
> 
> while (!cookies_.empty()) {
>   InternalDeleteCookie(cookies_.begin(),....);
> }

You're right, that's quite a bit nicer.  Done.

[mmenke, 2017-07-12 20:12:37]

LGTM, thanks for cleaning this up!

[commit-bot: I haz the power, 2017-07-12 21:00:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-12 21:00:54]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Randy Smith (Not in Mondays), 2017-07-13 01:24:37]

The CQ bit was checked by rdsmith@chromium.org

[commit-bot: I haz the power, 2017-07-13 01:25:00]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-13 03:09:59]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1499909077376870,
"parent_rev": "fa66128ad5e2960db19f64b5949962409cc55f95", "commit_rev":
"0e84cea67c8d24ab6a8d7cb1efdf5ec467c6dc38"}

[commit-bot: I haz the power, 2017-07-13 03:10:13]

Description was changed from

==========
Simplify CookieMonster::SetAllCookies{,Async}() implementation.

Given that for now the call must remain present but the precise semantics
of the call aren't important (see
https://codereview.chromium.org/2882063002/#msg64), it's worthwhile having
as clean and simple an implementation of reasonable semantics as possible.

BUG=None
R=mmenke@chromium.org
==========

to

==========
Simplify CookieMonster::SetAllCookies{,Async}() implementation.

Given that for now the call must remain present but the precise semantics
of the call aren't important (see
https://codereview.chromium.org/2882063002/#msg64), it's worthwhile having
as clean and simple an implementation of reasonable semantics as possible.

BUG=None
R=mmenke@chromium.org

Review-Url: https://codereview.chromium.org/2974363002
Cr-Commit-Position: refs/heads/master@{#486248}
Committed:
https://chromium.googlesource.com/chromium/src/+/0e84cea67c8d24ab6a8d7cb1efdf...
==========

[commit-bot: I haz the power, 2017-07-13 03:10:15]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/0e84cea67c8d24ab6a8d7cb1efdf...