Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(630)

Unified Diff: net/cookies/cookie_monster.h

Issue 2974363002: Simplify CookieMonster::SetAllCookies{,Async}() implementation. (Closed)
Patch Set: Sync['d up to latest PS on base CL. Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/cookies/cookie_monster.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cookies/cookie_monster.h
diff --git a/net/cookies/cookie_monster.h b/net/cookies/cookie_monster.h
index fe968dba700b051fb1d4cddd81dd2ea6d54159ca..717059e75ce0310a40525fc4ca6a81c30096af0f 100644
--- a/net/cookies/cookie_monster.h
+++ b/net/cookies/cookie_monster.h
@@ -149,8 +149,8 @@ class NET_EXPORT CookieMonster : public CookieStore {
~CookieMonster() override;
- // Writes all the cookies in |list| into the store, replacing existing
- // cookies that collide. Does not affect cookies not listed in |list|.
+ // Writes all the cookies in |list| into the store, replacing all cookies
+ // currently present in store.
// This method does not flush the backend.
// TODO(rdsmith, mmenke): Do not use this function; it is deprecated
// and should be removed.
@@ -255,9 +255,6 @@ class NET_EXPORT CookieMonster : public CookieStore {
// For FindCookiesForKey.
FRIEND_TEST_ALL_PREFIXES(CookieMonsterTest, ShortLivedSessionCookies);
- // For ComputeCookieDiff.
- FRIEND_TEST_ALL_PREFIXES(CookieMonsterTest, ComputeCookieDiff);
-
// For CookieSource histogram enum.
FRIEND_TEST_ALL_PREFIXES(CookieMonsterTest, CookieSourceHistogram);
@@ -638,16 +635,6 @@ class NET_EXPORT CookieMonster : public CookieStore {
// given URL are loaded.
void DoCookieCallbackForURL(base::OnceClosure callback, const GURL& url);
- // Computes the difference between |old_cookies| and |new_cookies|, and writes
- // the result in |cookies_to_add| and |cookies_to_delete|.
- // This function has the side effect of changing the order of |old_cookies|
- // and |new_cookies|. |cookies_to_add| and |cookies_to_delete| must be empty,
- // and none of the arguments can be null.
- void ComputeCookieDiff(CookieList* old_cookies,
- CookieList* new_cookies,
- CookieList* cookies_to_add,
- CookieList* cookies_to_delete);
-
// Run all cookie changed callbacks that are monitoring |cookie|.
// |removed| is true if the cookie was deleted.
void RunCookieChangedCallbacks(const CanonicalCookie& cookie,
« no previous file with comments | « no previous file | net/cookies/cookie_monster.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698