Remove bad CallJavascriptFunctionUnsafe call from PrintPreviewUI

Remove bad CallJavascriptFunctionUnsafe call from PrintPreviewUI

"cancelPendingPrintRequest" does not actually exist. Remove the call to
this function from the PrintPreviewUI.

BUG=740264
Review-Url: https://codereview.chromium.org/2974183002
Cr-Commit-Position: refs/heads/master@{#485982}
Committed: https://chromium.googlesource.com/chromium/src/+/a9e19eb6164aaa02e60c685a97fe4c579d0d03cb

[rbpotter, 2017-07-11 02:29:34]

The CQ bit was checked by rbpotter@chromium.org to run a CQ dry run

[rbpotter, 2017-07-11 02:29:44]

Description was changed from

==========
Remove bad CallJavascriptFunctionUnsafe call from PrintPreviewUI

"cancelPendingPrintRequest" does not actually exist. Remove the call to
this function from the PrintPreviewUI.

BUG=740264
==========

to

==========
Remove bad CallJavascriptFunctionUnsafe call from PrintPreviewUI

"cancelPendingPrintRequest" does not actually exist. Remove the call to
this function from the PrintPreviewUI.

BUG=740264
==========

[rbpotter, 2017-07-11 02:29:44]

rbpotter@chromium.org changed reviewers:
+ dpapad@chromium.org, thestig@chromium.org

[commit-bot: I haz the power, 2017-07-11 02:29:45]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-11 03:45:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-11 03:45:47]

Dry run: This issue passed the CQ dry run.

[dpapad, 2017-07-11 19:01:06]

LGTM

[Lei Zhang, 2017-07-11 19:23:08]

Is there a RegisterMessageCallback("cancelPendingPrintRequest", ...) call that
needs to be removed from PrintPreviewHandler::RegisterMessages() as well?

[rbpotter, 2017-07-11 19:25:59]

On 2017/07/11 19:23:08, Lei Zhang wrote:
> Is there a RegisterMessageCallback("cancelPendingPrintRequest", ...) call that
> needs to be removed from PrintPreviewHandler::RegisterMessages() as well?

No, because "cancelPendingPrintRequest" is a valid message from JS to the
Handler still (see
https://cs.chromium.org/chromium/src/chrome/browser/resources/print_preview/n...)
So the handler still needs to register the callback.

However it is not a Javascript function name so it does not make sense to
call it with CallJavascriptFunctionUnsafe.

[Lei Zhang, 2017-07-11 22:34:20]

lgtm

https://codereview.chromium.org/2974183002/diff/1/chrome/browser/ui/webui/pri...
File chrome/browser/ui/webui/print_preview/print_preview_handler.h (right):

https://codereview.chromium.org/2974183002/diff/1/chrome/browser/ui/webui/pri...
chrome/browser/ui/webui/print_preview/print_preview_handler.h:120: void
HandleCancelPendingPrintRequest(const base::ListValue* args);
Can we keep this methods protected, and add a new OnPrintRequestCancelled()
method. Ya, that would just call HandleCancelPendingPrintRequest(), which seems
silly, but it keeps up the pattern of only exposing OnFoo methods.

[rbpotter, 2017-07-11 23:27:15]

The CQ bit was checked by rbpotter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-11 23:28:01]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-11 23:31:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-11 23:31:36]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[rbpotter, 2017-07-12 00:07:27]

The CQ bit was checked by rbpotter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-12 00:08:19]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rbpotter, 2017-07-12 00:26:35]

https://codereview.chromium.org/2974183002/diff/1/chrome/browser/ui/webui/pri...
File chrome/browser/ui/webui/print_preview/print_preview_handler.h (right):

https://codereview.chromium.org/2974183002/diff/1/chrome/browser/ui/webui/pri...
chrome/browser/ui/webui/print_preview/print_preview_handler.h:120: void
HandleCancelPendingPrintRequest(const base::ListValue* args);
On 2017/07/11 22:34:20, Lei Zhang wrote:
> Can we keep this methods protected, and add a new OnPrintRequestCancelled()
> method. Ya, that would just call HandleCancelPendingPrintRequest(), which
seems
> silly, but it keeps up the pattern of only exposing OnFoo methods.

Done.

[commit-bot: I haz the power, 2017-07-12 02:27:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-12 02:27:59]

Dry run: This issue passed the CQ dry run.

[rbpotter, 2017-07-12 16:01:08]

The CQ bit was checked by rbpotter@chromium.org

[rbpotter, 2017-07-12 16:01:08]

The patchset sent to the CQ was uploaded after l-g-t-m from
thestig@chromium.org, dpapad@chromium.org
Link to the patchset: https://codereview.chromium.org/2974183002/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2017-07-12 16:01:24]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-12 16:09:56]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1499875268005980,
"parent_rev": "026d677f76a4c804ce89055921373d54275f9805", "commit_rev":
"a9e19eb6164aaa02e60c685a97fe4c579d0d03cb"}

[commit-bot: I haz the power, 2017-07-12 16:10:11]

Description was changed from

==========
Remove bad CallJavascriptFunctionUnsafe call from PrintPreviewUI

"cancelPendingPrintRequest" does not actually exist. Remove the call to
this function from the PrintPreviewUI.

BUG=740264
==========

to

==========
Remove bad CallJavascriptFunctionUnsafe call from PrintPreviewUI

"cancelPendingPrintRequest" does not actually exist. Remove the call to
this function from the PrintPreviewUI.

BUG=740264

Review-Url: https://codereview.chromium.org/2974183002
Cr-Commit-Position: refs/heads/master@{#485982}
Committed:
https://chromium.googlesource.com/chromium/src/+/a9e19eb6164aaa02e60c685a97fe...
==========

[commit-bot: I haz the power, 2017-07-12 16:10:13]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/a9e19eb6164aaa02e60c685a97fe...