Remove bad CallJavascriptFunctionUnsafe call from PrintPreviewUI

chrome/browser/ui/webui/print_preview/print_preview_handler.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_WEBUI_PRINT_PREVIEW_PRINT_PREVIEW_HANDLER_H_
 #define CHROME_BROWSER_UI_WEBUI_PRINT_PREVIEW_PRINT_PREVIEW_HANDLER_H_
 
 #include <memory>
 #include <queue>
 #include <string>
@@ skipping 98 matching lines @@
       int http_code) override;
 #endif
 
   int regenerate_preview_request_count() const {
     return regenerate_preview_request_count_;
   }
 
   // Sets |pdf_file_saved_closure_| to |closure|.
   void SetPdfSavedClosureForTesting(const base::Closure& closure);
 
+  // Handles the request to cancel the pending print request. |args| is unused.
+  void HandleCancelPendingPrintRequest(const base::ListValue* args);

[Lei Zhang, 2017/07/11 22:34:20]

Can we keep this methods protected, and add a new OnPrintRequestCancelled()
method. Ya, that would just call HandleCancelPendingPrintRequest(), which seems
silly, but it keeps up the pattern of only exposing OnFoo methods.

[rbpotter, 2017/07/12 00:26:35]

Done.

+
  protected:
   // If |prompt_user| is true, starts a task to create the default Save As PDF
   // directory if needed. OnDirectoryCreated() will be called when it
   // finishes to open the modal dialog and prompt the user. Otherwise, just
   // accept |default_path| and uniquify it.
   // Protected so unit tests can access.
   virtual void SelectFile(const base::FilePath& default_path, bool prompt_user);
 
   // Handles printing to PDF. Protected to expose to unit tests.
   void PrintToPdf();
@@ skipping 31 matching lines @@
   void HandleGetPreview(const base::ListValue* args);
 
   // Gets the job settings from Web UI and initiate printing. First element of
   // |args| is a job settings JSON string.
   void HandlePrint(const base::ListValue* args);
 
   // Handles the request to hide the preview dialog for printing.
   // |args| is unused.
   void HandleHidePreview(const base::ListValue* args);
 
-  // Handles the request to cancel the pending print request. |args| is unused.
-  void HandleCancelPendingPrintRequest(const base::ListValue* args);
-
   // Handles a request to store data that the web ui wishes to persist.
   // First element of |args| is the data to persist.
   void HandleSaveAppState(const base::ListValue* args);
 
   // Gets the printer capabilities. First element of |args| is the printer name.
   void HandleGetPrinterCapabilities(const base::ListValue* args);
 
   // Performs printer setup. First element of |args| is the printer name.
   void HandlePrinterSetup(const base::ListValue* args);
 
@@ skipping 268 matching lines @@
   // Proxy for calls to the print backend.  Lazily initialized since web_ui() is
   // not available at construction time.
   std::unique_ptr<printing::PrinterBackendProxy> printer_backend_proxy_;
 
   base::WeakPtrFactory<PrintPreviewHandler> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(PrintPreviewHandler);
 };
 
 #endif  // CHROME_BROWSER_UI_WEBUI_PRINT_PREVIEW_PRINT_PREVIEW_HANDLER_H_