Implement AccessibleNode.hasPopUp for Accessibility Object Model phase 1

Implement AccessibleNode.hasPopUp for Accessibility Object Model phase 1

This is the last AOM phase 1 property! I missed it earlier because it used
to be a boolean attribute but in ARIA 1.1 it was changed to a string.
This change just hooks up the AOM portion, but I filed bug 740137 to
track plumbing through the string value of haspopup rahter than treating
it as a boolean elsewhere.

BUG=680345, 740137
Review-Url: https://codereview.chromium.org/2973973002
Cr-Commit-Position: refs/heads/master@{#487773}
Committed: https://chromium.googlesource.com/chromium/src/+/fee38fe5d637a5f0ea3d06708ec12a9981fce6bb

[dmazzoni, 2017-07-07 16:00:37]

The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-07 16:00:52]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dmazzoni, 2017-07-07 16:02:09]

dmazzoni@chromium.org changed reviewers:
+ aboxhall@chromium.org, mkwst@chromium.org

[dmazzoni, 2017-07-07 16:27:24]

The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-07 16:27:43]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-07 16:33:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-07 16:33:21]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  linux_chromium_headless_rel on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Mike West, 2017-07-11 17:26:43]

LGTM after a rebase. Sorry, I've been looking at Gerrit, and kinda forgot
Reitveld was still there. *cough*

[dmazzoni, 2017-07-17 07:06:46]

Unfortunately I'm stuck with a machine that's unable to upload patches to
Gerrit. :( Infra bug has been open for a month. I'm happily uploading to
Gerrit from my other machines, but not from this one...


On Tue, Jul 11, 2017 at 10:26 AM <mkwst@chromium.org> wrote:

> LGTM after a rebase. Sorry, I've been looking at Gerrit, and kinda forgot
> Reitveld was still there. *cough*
>
> https://codereview.chromium.org/2973973002/
>

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[dmazzoni, 2017-07-17 07:06:47]

Unfortunately I'm stuck with a machine that's unable to upload patches to
Gerrit. :( Infra bug has been open for a month. I'm happily uploading to
Gerrit from my other machines, but not from this one...


On Tue, Jul 11, 2017 at 10:26 AM <mkwst@chromium.org> wrote:

> LGTM after a rebase. Sorry, I've been looking at Gerrit, and kinda forgot
> Reitveld was still there. *cough*
>
> https://codereview.chromium.org/2973973002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[dmazzoni, 2017-07-17 23:41:18]

The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-17 23:41:26]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-18 00:15:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-18 00:15:01]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[dmazzoni, 2017-07-19 00:32:21]

The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-19 00:32:34]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-19 02:21:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-19 02:21:37]

Dry run: This issue passed the CQ dry run.

[dmazzoni, 2017-07-19 06:30:30]

The CQ bit was checked by dmazzoni@chromium.org

[dmazzoni, 2017-07-19 06:30:31]

The patchset sent to the CQ was uploaded after l-g-t-m from mkwst@chromium.org
Link to the patchset: https://codereview.chromium.org/2973973002/#ps80001
(title: "Fix handling of aria-haspopup=false")

[commit-bot: I haz the power, 2017-07-19 06:30:43]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-19 06:38:45]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1500445830875600,
"parent_rev": "c752d50fc612696c0357834728d0c6e73bfc01b1", "commit_rev":
"fee38fe5d637a5f0ea3d06708ec12a9981fce6bb"}

[commit-bot: I haz the power, 2017-07-19 06:39:00]

Description was changed from

==========
Implement AccessibleNode.hasPopUp for Accessibility Object Model phase 1

This is the last AOM phase 1 property! I missed it earlier because it used
to be a boolean attribute but in ARIA 1.1 it was changed to a string.
This change just hooks up the AOM portion, but I filed bug 740137 to
track plumbing through the string value of haspopup rahter than treating
it as a boolean elsewhere.

BUG=680345,740137
==========

to

==========
Implement AccessibleNode.hasPopUp for Accessibility Object Model phase 1

This is the last AOM phase 1 property! I missed it earlier because it used
to be a boolean attribute but in ARIA 1.1 it was changed to a string.
This change just hooks up the AOM portion, but I filed bug 740137 to
track plumbing through the string value of haspopup rahter than treating
it as a boolean elsewhere.

BUG=680345,740137

Review-Url: https://codereview.chromium.org/2973973002
Cr-Commit-Position: refs/heads/master@{#487773}
Committed:
https://chromium.googlesource.com/chromium/src/+/fee38fe5d637a5f0ea3d06708ec1...
==========

[commit-bot: I haz the power, 2017-07-19 06:39:02]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/fee38fe5d637a5f0ea3d06708ec1...