third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp - Issue 2973973002: Implement AccessibleNode.hasPopUp for Accessibility Object Model phase 1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp

Issue 2973973002: Implement AccessibleNode.hasPopUp for Accessibility Object Model phase 1 (Closed)

Patch Set: Fix handling of aria-haspopup=false Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp

diff --git a/third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp b/third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp

index 6ec4a83678c7dabecb04bfa9a855b0987899e4b3..fa0c1f71a03feef8fcd62f1e79ca1e0ad508e6b1 100644

--- a/third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp

+++ b/third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp

@@ -165,8 +165,8 @@ void FillWidgetProperties(AXObject& ax_object,

CreateProperty(AXWidgetAttributesEnum::Autocomplete,

CreateValue(autocomplete, AXValueTypeEnum::Token)));

- if (ax_object.HasAttribute(HTMLNames::aria_haspopupAttr)) {

- bool has_popup = ax_object.AriaHasPopup();

+ bool has_popup = ax_object.AriaHasPopup();

+ if (has_popup || ax_object.HasAttribute(HTMLNames::aria_haspopupAttr)) {

properties.addItem(CreateProperty(AXWidgetAttributesEnum::Haspopup,

CreateBooleanValue(has_popup)));

}

« no previous file with comments | « third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp ('k') | no next file » | no next file with comments »