Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2973783002:
[MD Bookmarks] Prevent sorting of empty folders. (Closed)
Description[MD Bookmarks] Prevent sorting of empty folders.
This CL disables the sort button in the toolbar action menu for empty
folders.
BUG=737034
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2973783002
Cr-Commit-Position: refs/heads/master@{#485563}
Committed: https://chromium.googlesource.com/chromium/src/+/a9256bd64c54c4194f63cc084612536e3e53ae0a
Patch Set 1 : #
Total comments: 2
Patch Set 2 : remove flushes #
Messages
Total messages: 28 (23 generated)
Description was changed from ========== [MD Bookmarks] Prevent sorting of empty folders. This CL disables the sort button in the toolbar action menu for empty folders. BUG=737034 ========== to ========== [MD Bookmarks] Prevent sorting of empty folders. This CL disables the sort button in the toolbar action menu for empty folders. BUG=737034 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by calamity@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by calamity@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #1 (id:1) has been deleted
Patchset #1 (id:20001) has been deleted
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
The CQ bit was checked by calamity@chromium.org to run a CQ dry run
Patchset #1 (id:40001) has been deleted
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
calamity@chromium.org changed reviewers: + tsergeant@chromium.org
lgtm https://codereview.chromium.org/2973783002/diff/60001/chrome/test/data/webui/... File chrome/test/data/webui/md_bookmarks/toolbar_test.js (right): https://codereview.chromium.org/2973783002/diff/60001/chrome/test/data/webui/... chrome/test/data/webui/md_bookmarks/toolbar_test.js:123: Polymer.dom.flush(); Nit: Are these flushes actually necessary? I wouldn't really expect them to be, so remove them if you can.
The CQ bit was checked by calamity@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_clang on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)
https://codereview.chromium.org/2973783002/diff/60001/chrome/test/data/webui/... File chrome/test/data/webui/md_bookmarks/toolbar_test.js (right): https://codereview.chromium.org/2973783002/diff/60001/chrome/test/data/webui/... chrome/test/data/webui/md_bookmarks/toolbar_test.js:123: Polymer.dom.flush(); On 2017/07/10 07:09:08, tsergeant wrote: > Nit: Are these flushes actually necessary? I wouldn't really expect them to be, > so remove them if you can. Done.
The CQ bit was checked by calamity@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from tsergeant@chromium.org Link to the patchset: https://codereview.chromium.org/2973783002/#ps80001 (title: "remove flushes")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 80001, "attempt_start_ts": 1499756003113740,
"parent_rev": "a8283ee78bf919fb2c785d4741c7677bec6a855b", "commit_rev":
"a9256bd64c54c4194f63cc084612536e3e53ae0a"}
Message was sent while issue was closed.
Description was changed from ========== [MD Bookmarks] Prevent sorting of empty folders. This CL disables the sort button in the toolbar action menu for empty folders. BUG=737034 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== [MD Bookmarks] Prevent sorting of empty folders. This CL disables the sort button in the toolbar action menu for empty folders. BUG=737034 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2973783002 Cr-Commit-Position: refs/heads/master@{#485563} Committed: https://chromium.googlesource.com/chromium/src/+/a9256bd64c54c4194f63cc084612... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:80001) as https://chromium.googlesource.com/chromium/src/+/a9256bd64c54c4194f63cc084612... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
