Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11505)

Unified Diff: chrome/test/data/webui/md_bookmarks/toolbar_test.js

Issue 2973783002: [MD Bookmarks] Prevent sorting of empty folders. (Closed)
Patch Set: remove flushes Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/md_bookmarks/toolbar.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/webui/md_bookmarks/toolbar_test.js
diff --git a/chrome/test/data/webui/md_bookmarks/toolbar_test.js b/chrome/test/data/webui/md_bookmarks/toolbar_test.js
index f01fcf6d90dbe7d02345fb3e682353a476abf0d0..9fa23a0533117bec1439257b8641996f58eeca77 100644
--- a/chrome/test/data/webui/md_bookmarks/toolbar_test.js
+++ b/chrome/test/data/webui/md_bookmarks/toolbar_test.js
@@ -19,6 +19,12 @@ suite('<bookmarks-toolbar>', function() {
createItem('2'),
createItem('3'),
createFolder('4', [], {unmodifiable: 'managed'}),
+ createFolder('5', []),
+ createFolder(
+ '6',
+ [
+ createItem('61'),
+ ]),
])),
selection: {
items: new Set(),
@@ -108,4 +114,18 @@ suite('<bookmarks-toolbar>', function() {
assertTrue(toolbar.$$('#addBookmarkButton').disabled);
assertTrue(toolbar.$$('#importBookmarkButton').disabled);
});
+
+ test('sort button is disabled when folder is empty', function() {
+ MockInteractions.tap(toolbar.$.menuButton);
+
+ store.data.selectedFolder = '6';
+ store.notifyObservers();
+ assertTrue(toolbar.canSortFolder_);
+
+ store.data.selectedFolder = '5';
+ store.notifyObservers();
+
+ assertFalse(toolbar.canSortFolder_);
+ assertTrue(toolbar.$$('#sortButton').disabled);
+ });
});
« no previous file with comments | « chrome/browser/resources/md_bookmarks/toolbar.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698