Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 2973253003: Revert of [System Health] Extend dump time to 5 seconds (Closed)

Created:
3 years, 5 months ago by perezju
Modified:
3 years, 5 months ago
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Revert of [System Health] Extend dump time to 5 seconds (patchset #2 id:20001 of https://codereview.chromium.org/2946013004/ ) Reason for revert: Did not provide intended effect on the waterfall. Note to perf sheriffs: This is expected to cause several metric values to shift. Original issue's description: > [System Health] Extend dump time to 5 seconds > > Experiments have shown this significantly reduces noise > levels un gpu and cc memory infra metrics. > > BUG=chromium:734853 > > Review-Url: https://codereview.chromium.org/2946013004 > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/b4eb70c319cb0f38d1a7764e7d9fb56dc96f8bcf TBR=ericrk@chromium.org,nednguyen@google.com,primiano@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:734853 Review-Url: https://codereview.chromium.org/2973253003 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/00b0c16c97088f5c06df9d3b27eaeb41f06173e5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M telemetry/telemetry/internal/actions/action_runner.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
perezju
Created Revert of [System Health] Extend dump time to 5 seconds
3 years, 5 months ago (2017-07-08 08:53:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2973253003/1
3 years, 5 months ago (2017-07-08 08:53:42 UTC) #3
commit-bot: I haz the power
3 years, 5 months ago (2017-07-08 09:18:57 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698