Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(553)

Issue 2946013004: [System Health] Extend dump time to 5 seconds (Closed)

Created:
3 years, 6 months ago by perezju
Modified:
3 years, 5 months ago
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

[System Health] Extend dump time to 5 seconds Experiments have shown this significantly reduces noise levels un gpu and cc memory infra metrics. BUG=chromium:734853 Review-Url: https://codereview.chromium.org/2946013004 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/b4eb70c319cb0f38d1a7764e7d9fb56dc96f8bcf

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M telemetry/telemetry/internal/actions/action_runner.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
perezju
3 years, 5 months ago (2017-06-26 10:42:24 UTC) #3
Primiano Tucci (use gerrit)
lgtm
3 years, 5 months ago (2017-06-26 12:06:01 UTC) #4
nednguyen
On 2017/06/26 12:06:01, Primiano Tucci wrote: > lgtm I think we may need to extend ...
3 years, 5 months ago (2017-06-26 13:20:00 UTC) #5
perezju
On 2017/06/26 at 13:20:00, nednguyen wrote: > On 2017/06/26 12:06:01, Primiano Tucci wrote: > > ...
3 years, 5 months ago (2017-06-26 13:52:54 UTC) #6
nednguyen
On 2017/06/26 13:52:54, perezju wrote: > On 2017/06/26 at 13:20:00, nednguyen wrote: > > On ...
3 years, 5 months ago (2017-06-26 13:58:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2946013004/20001
3 years, 5 months ago (2017-06-26 14:00:51 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/b4eb70c319cb0f38d1a7764e7d9fb56dc96f8bcf
3 years, 5 months ago (2017-06-26 14:25:48 UTC) #12
perezju
3 years, 5 months ago (2017-07-08 08:53:33 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2973253003/ by perezju@chromium.org.

The reason for reverting is: Did not provide intended effect on the waterfall.

Note to perf sheriffs: This is expected to cause several metric values to
shift..

Powered by Google App Engine
This is Rietveld 408576698