Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 297313002: Revert 272769 "Revert 272672 "Attempt #4: Change Skia DEPS to pu..." (Closed)

Created:
6 years, 7 months ago by tapted
Modified:
6 years, 7 months ago
Reviewers:
tapted
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 272769 "Revert 272672 "Attempt #4: Change Skia DEPS to pu..." Still failing - will need infra to take a look. > Revert 272672 "Attempt #4: Change Skia DEPS to pull from googles..." > > Waterfall Builder: iOS Simulator (dbg) is failing in bot_update since > > http://build.chromium.org/p/chromium.mac/builders/iOS%20Simulator%20%28dbg%29/builds/16396 > > Suspecting this. Will unrevert if not. > > BUG=377342 > > > Attempt #4: Change Skia DEPS to pull from googlesource (git) > > > > - Uploading from pure-svn and intending to commit manually to properly remove the directory from svn. > > - Includes deps_whitelist change for new Skia DEP > > - Attempt #3 failed due to Poppler license issue. This was resolved in https://skia.googlesource.com/skia/+/3056bdd2364fe1aa68f4ec7b0fe07740c3e8d123 > > > > R=mkosiba@chromium.org > > > > Review URL: https://codereview.chromium.org/296903004 > > TBR=borenet@google.com > > Review URL: https://codereview.chromium.org/297303002 TBR=tapted@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272771

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -47 lines) Patch
M trunk/src/DEPS View 2 chunks +3 lines, -10 lines 0 comments Download
M trunk/src/android_webview/buildbot/deps_whitelist.py View 1 chunk +1 line, -3 lines 0 comments Download
D trunk/src/third_party/skia/LICENSE View 1 chunk +0 lines, -27 lines 0 comments Download
D trunk/src/third_party/skia/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D trunk/src/third_party/skia/README.chromium View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tapted
6 years, 7 months ago (2014-05-26 02:31:00 UTC) #1
tapted
6 years, 7 months ago (2014-05-26 02:31:51 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r272771 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698