Issue 296903004: Attempt #4: Change Skia DEPS to pull from googlesource (git)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 296903004: Attempt #4: Change Skia DEPS to pull from googlesource (git) (Closed)

Created:
6 years, 7 months ago by borenet

Modified:
6 years, 7 months ago

Reviewers:
Torne, iannucci, mkosiba (inactive), boliu, luqui, agable

CC:
chromium-reviews, android-webview-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Attempt #4: Change Skia DEPS to pull from googlesource (git) - Uploading from pure-svn and intending to commit manually to properly remove the directory from svn. - Includes deps_whitelist change for new Skia DEP - Attempt #3 failed due to Poppler license issue. This was resolved in https://skia.googlesource.com/skia/+/3056bdd2364fe1aa68f4ec7b0fe07740c3e8d123 R=mkosiba@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272672

Patch Set 1 #

Patch Set 2 : Rebase #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -47 lines)			Patch
M	DEPS	View	1	2 chunks	+3 lines, -10 lines	0 comments	Download
M	android_webview/buildbot/deps_whitelist.py	View	1	1 chunk	+1 line, -3 lines	0 comments	Download
D	third_party/skia/LICENSE	View	1	1 chunk	+0 lines, -27 lines	0 comments	Download
D	third_party/skia/OWNERS	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
D	third_party/skia/README.chromium	View	1	1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

tapted

6 years, 7 months ago (2014-05-26 23:49:40 UTC) #4

Message was sent while issue was closed.

On 2014/05/24 01:29:13, borenet wrote:
> Committed patchset #2 manually as r272672.

Just so there's a document trail here. In an attempt to fix
http://crbug.com/377342 I tried a revert of this CL in
https://codereview.chromium.org/297303002/ . Seemed to have no effect, so it was
un-reverted in https://codereview.chromium.org/297313002/

Expand Messages | Collapse Messages