Issue 297303002: Revert 272672 "Attempt #4: Change Skia DEPS to pull from googles..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 297303002: Revert 272672 "Attempt #4: Change Skia DEPS to pull from googles..." (Closed)

Created:
6 years, 7 months ago by tapted

Modified:
6 years, 7 months ago

Reviewers:
borenet

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 272672 "Attempt #4: Change Skia DEPS to pull from googles..." Waterfall Builder: iOS Simulator (dbg) is failing in bot_update since http://build.chromium.org/p/chromium.mac/builders/iOS%20Simulator%20%28dbg%29/builds/16396 Suspecting this. Will unrevert if not. BUG=377342 > Attempt #4: Change Skia DEPS to pull from googlesource (git) > > - Uploading from pure-svn and intending to commit manually to properly remove the directory from svn. > - Includes deps_whitelist change for new Skia DEP > - Attempt #3 failed due to Poppler license issue. This was resolved in https://skia.googlesource.com/skia/+/3056bdd2364fe1aa68f4ec7b0fe07740c3e8d123 > > R=mkosiba@chromium.org > > Review URL: https://codereview.chromium.org/296903004 TBR=borenet@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272769

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -1 line)			Patch
M	trunk/src/DEPS	View	2 chunks	+10 lines, -3 lines	0 comments	Download
M	trunk/src/android_webview/buildbot/deps_whitelist.py	View	1 chunk	+3 lines, -1 line	0 comments	Download
A +	trunk/src/third_party/skia/LICENSE	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	trunk/src/third_party/skia/OWNERS	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	trunk/src/third_party/skia/README.chromium	View	0 chunks	+-1 lines, --1 lines	0 comments	Download

Total messages: 2 (0 generated)

tapted

6 years, 7 months ago (2014-05-26 02:02:10 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r272769 (tree was closed).