Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3563)

Unified Diff: extensions/browser/extension_registry.h

Issue 297263003: Optimize promotion of ephemeral apps (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/extension_registry.h
diff --git a/extensions/browser/extension_registry.h b/extensions/browser/extension_registry.h
index 0087645d08949fb3e071572a40aa4a5b44a7c5fd..646863c224623475d3b242333fe033699ad582bd 100644
--- a/extensions/browser/extension_registry.h
+++ b/extensions/browser/extension_registry.h
@@ -78,8 +78,12 @@ class ExtensionRegistry : public KeyedService {
// any installed extension with |extension|'s ID. If this is an update then
// |is_update| is true and must be an installed extension with |extension|'s
// ID, and |old_name| must be non-empty.
+ // If true, |from_ephemeral| indicates that the extension was previously
+ // installed ephemerally and has been promoted to a regular installed
+ // extension. |is_update| should also be true.
benwells 2014/05/27 01:42:56 Please add a TODO to remove these historical param
tmdiep 2014/05/27 07:46:05 Done.
void TriggerOnWillBeInstalled(const Extension* extension,
bool is_update,
+ bool from_ephemeral,
const std::string& old_name);
// Invokes the observer method OnExtensionUninstalled(). The extension must

Powered by Google App Engine
This is Rietveld 408576698