Optimize promotion of ephemeral apps

extensions/browser/extension_prefs.h

Index: extensions/browser/extension_prefs.h
diff --git a/extensions/browser/extension_prefs.h b/extensions/browser/extension_prefs.h
index 9ffcf11c0059a4483408f2dd8d14695b9db756e3..5d3712a2bd72315903dcfc77595904920d6daa12 100644
--- a/extensions/browser/extension_prefs.h
+++ b/extensions/browser/extension_prefs.h
@@ -480,6 +480,9 @@ class ExtensionPrefs : public ExtensionScopedPrefs, public KeyedService {
   // Returns true if the extension is an ephemeral app.
   bool IsEphemeralApp(const std::string& extension_id) const;
 
+  // Promotes an ephemeral app to a regular installed app.
+  void OnEphemeralAppInstalled(const std::string& extension_id);

[benwells, 2014/05/27 01:42:56]

Same here, the name alone is confusing. Suggest
OnEphemeralAppInstalledPermanently.

[tmdiep, 2014/05/27 01:58:54]

Yeah, this was the original name as well. What about "OnEphemeralAppPromoted",
or is this even more confusing??

[benwells, 2014/05/27 03:11:11]

sgtm.

[tmdiep, 2014/05/27 07:46:05]

Done.

+
   // Returns true if the user repositioned the app on the app launcher via drag
   // and drop.
   bool WasAppDraggedByUser(const std::string& extension_id);