Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2972463003: Use DartEditBuilder to write types and remove dead code (Closed)

Created:
3 years, 5 months ago by Brian Wilkerson
Modified:
3 years, 5 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use DartEditBuilder to write types and remove dead code R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/aadafd1bd53a33766a873ac880fd03e415cc9db9

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -190 lines) Patch
M pkg/analysis_server/lib/src/services/correction/assist_internal.dart View 5 chunks +42 lines, -59 lines 0 comments Download
M pkg/analysis_server/lib/src/services/correction/util.dart View 3 chunks +0 lines, -124 lines 0 comments Download
M pkg/analysis_server/test/services/correction/assist_test.dart View 1 chunk +3 lines, -0 lines 1 comment Download
M pkg/analyzer_plugin/lib/src/utilities/change_builder/change_builder_dart.dart View 4 chunks +28 lines, -7 lines 0 comments Download
M pkg/analyzer_plugin/lib/utilities/change_builder/change_builder_dart.dart View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
Please look at the question in the now failing test and let me know what ...
3 years, 5 months ago (2017-07-01 15:10:12 UTC) #2
scheglov
LGTM https://codereview.chromium.org/2972463003/diff/1/pkg/analysis_server/test/services/correction/assist_test.dart File pkg/analysis_server/test/services/correction/assist_test.dart (right): https://codereview.chromium.org/2972463003/diff/1/pkg/analysis_server/test/services/correction/assist_test.dart#newcode172 pkg/analysis_server/test/services/correction/assist_test.dart:172: // Is it really better to produce nothing? ...
3 years, 5 months ago (2017-07-01 15:31:18 UTC) #3
Brian Wilkerson
3 years, 5 months ago (2017-07-01 19:03:51 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
aadafd1bd53a33766a873ac880fd03e415cc9db9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698