pkg/analyzer_plugin/lib/utilities/change_builder/change_builder_dart.dart - Issue 2972463003: Use DartEditBuilder to write types and remove dead code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analyzer_plugin/lib/utilities/change_builder/change_builder_dart.dart

Issue 2972463003: Use DartEditBuilder to write types and remove dead code (Closed)

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/analysis_server/test/services/correction/assist_test.dart ('K') | « pkg/analyzer_plugin/lib/src/utilities/change_builder/change_builder_dart.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analyzer_plugin/lib/utilities/change_builder/change_builder_dart.dart

diff --git a/pkg/analyzer_plugin/lib/utilities/change_builder/change_builder_dart.dart b/pkg/analyzer_plugin/lib/utilities/change_builder/change_builder_dart.dart

index 283a27136a3d20f35a4d5e0a625271bbe5066a39..755e0efdf344042fac5592e4f04276ad95859f72 100644

--- a/pkg/analyzer_plugin/lib/utilities/change_builder/change_builder_dart.dart

+++ b/pkg/analyzer_plugin/lib/utilities/change_builder/change_builder_dart.dart

@@ -226,6 +226,8 @@ abstract class DartEditBuilder implements EditBuilder {

* If a [methodBeingCopied] is provided, then type parameters defined by that

* method are assumed to be part of what is being written and hence valid

* types.

+ *

+ * Return `true` if some text was written.

bool writeType(DartType type,

{bool addSupertypeProposals: false,