Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: pkg/analysis_server/test/services/correction/assist_test.dart

Issue 2972463003: Use DartEditBuilder to write types and remove dead code (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/lib/src/services/correction/util.dart ('k') | pkg/analyzer_plugin/lib/src/utilities/change_builder/change_builder_dart.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/test/services/correction/assist_test.dart
diff --git a/pkg/analysis_server/test/services/correction/assist_test.dart b/pkg/analysis_server/test/services/correction/assist_test.dart
index b8de651c44b21fa45646c4facd0374d0a0b5eff4..7af0f29c3ce676923a9e0670bc8d388cddb23d5f 100644
--- a/pkg/analysis_server/test/services/correction/assist_test.dart
+++ b/pkg/analysis_server/test/services/correction/assist_test.dart
@@ -166,7 +166,10 @@ class A<T> {
await assertNoAssistAt('var item', DartAssistKind.ADD_TYPE_ANNOTATION);
}
+ @failingTest
test_addTypeAnnotation_BAD_privateType_list() async {
+ // This is now failing because we're suggesting "List" rather than nothing.
+ // Is it really better to produce nothing?
scheglov 2017/07/01 15:31:18 "List" would also be OK.
addSource(
'/my_lib.dart',
'''
« no previous file with comments | « pkg/analysis_server/lib/src/services/correction/util.dart ('k') | pkg/analyzer_plugin/lib/src/utilities/change_builder/change_builder_dart.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698