Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Issue 297233010: Revert 273108 "Omaha configuration parameters now use Wow6432Nod..." (Closed)

Created:
6 years, 7 months ago by dxie1
Modified:
6 years, 7 months ago
Reviewers:
Will Harris
CC:
chromium-reviews, grt+watch_chromium.org
Visibility:
Public.

Description

Revert 273108 "Omaha configuration parameters now use Wow6432Nod..." > Omaha configuration parameters now use Wow6432Node (32-bit registry) on 64-bit installs. GCAPI configuration parameters also use these same accesses since they read/write the same data. > > Also, force installation of Win64 into C:\Program Files (x86) until the code is added to support moving the files to the right place during upgrade and downgrade. Uninstall information will remain stored in the 32-bit registry (even on 64-bit) until the installation location is changed. > > This fixes system installs on Win64. > > BUG=338706 > R=grt@chromium.org > > Review URL: https://codereview.chromium.org/300593002 TBR=wfh@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273138

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -197 lines) Patch
M chrome/installer/gcapi/gcapi.cc View 6 chunks +9 lines, -15 lines 0 comments Download
M chrome/installer/gcapi/gcapi_last_run_test.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M chrome/installer/gcapi/gcapi_reactivation.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M chrome/installer/gcapi/gcapi_reactivation_test.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/installer/mini_installer/mini_installer.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/installer/setup/install_worker.cc View 27 chunks +60 lines, -61 lines 0 comments Download
M chrome/installer/setup/setup_main.cc View 1 chunk +7 lines, -11 lines 0 comments Download
M chrome/installer/setup/uninstall.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M chrome/installer/util/app_command.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M chrome/installer/util/compat_checks.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/installer/util/google_chrome_distribution.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/installer/util/google_update_settings.cc View 14 chunks +23 lines, -36 lines 0 comments Download
M chrome/installer/util/helper.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/installer/util/install_util.cc View 6 chunks +12 lines, -15 lines 0 comments Download
M chrome/installer/util/installation_state.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M chrome/installer/util/installer_state.cc View 2 chunks +4 lines, -8 lines 0 comments Download
M chrome/installer/util/product.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/installer/util/shell_util.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
dxie1
6 years, 7 months ago (2014-05-28 03:11:58 UTC) #1
dxie1
6 years, 7 months ago (2014-05-28 03:12:46 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r273138.

Powered by Google App Engine
This is Rietveld 408576698