chrome/installer/gcapi/gcapi_last_run_test.cc - Issue 297233010: Revert 273108 "Omaha configuration parameters now use Wow6432Nod..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/gcapi/gcapi_last_run_test.cc

Issue 297233010: Revert 273108 "Omaha configuration parameters now use Wow6432Nod..." (Closed) Base URL: svn://svn.chromium.org/chrome/branches/2017/src/

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/installer/gcapi/gcapi_last_run_test.cc

===================================================================

--- chrome/installer/gcapi/gcapi_last_run_test.cc (revision 273136)

+++ chrome/installer/gcapi/gcapi_last_run_test.cc (working copy)

@@ -36,7 +36,7 @@

reg_path += google_update::kChromeUpgradeCode;

RegKey client_state(HKEY_CURRENT_USER,

reg_path.c_str(),

- KEY_CREATE_SUB_KEY | KEY_WOW64_32KEY);

+ KEY_CREATE_SUB_KEY);

ASSERT_TRUE(client_state.Valid());

// Place a bogus "pv" value in the right places to make the last run

@@ -46,7 +46,7 @@

clients_path += google_update::kChromeUpgradeCode;

RegKey client_key(HKEY_CURRENT_USER,

clients_path.c_str(),

- KEY_CREATE_SUB_KEY | KEY_SET_VALUE | KEY_WOW64_32KEY);

+ KEY_CREATE_SUB_KEY | KEY_SET_VALUE);

ASSERT_TRUE(client_key.Valid());

client_key.WriteValue(L"pv", L"1.2.3.4");

}

@@ -61,8 +61,7 @@

path += L"\\";

path += google_update::kChromeUpgradeCode;

- RegKey client_state(

- HKEY_CURRENT_USER, path.c_str(), KEY_SET_VALUE | KEY_WOW64_32KEY);

+ RegKey client_state(HKEY_CURRENT_USER, path.c_str(), KEY_SET_VALUE);

return (client_state.Valid() &&

client_state.WriteValue(

google_update::kRegLastRunTimeField,

« no previous file with comments | « chrome/installer/gcapi/gcapi.cc ('k') | chrome/installer/gcapi/gcapi_reactivation.cc » ('j') | no next file with comments »