Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4666)

Unified Diff: chrome/common/render_messages.h

Issue 2972123002: Click to Open PDF: Open PDF once View PDF is clicked. (Closed)
Patch Set: Rename from download to open PDF Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/render_messages.h
diff --git a/chrome/common/render_messages.h b/chrome/common/render_messages.h
index 625a4b3a9f4b84d418571580656469758535661f..d554d5c7d3b34948f7b40b0fe90d32fc628a3ccf 100644
--- a/chrome/common/render_messages.h
+++ b/chrome/common/render_messages.h
@@ -341,3 +341,7 @@ IPC_MESSAGE_CONTROL2(ChromeViewMsg_SetSearchURLs,
IPC_SYNC_MESSAGE_CONTROL0_1(ChromeViewHostMsg_IsCrashReportingEnabled,
bool /* enabled */)
#endif
+
+// Tells the browser to open a PDF file in a new tab. Used when plugins are
Lei Zhang 2017/07/07 22:47:58 plugins are disabled -> there is no PDF viewer ava
amberwon 2017/07/11 18:08:05 I believe just Chrome's PDF Viewer is disabled, bu
Lei Zhang 2017/07/12 00:51:37 If one disables the internal PDF Viewer and instal
amberwon 2017/07/12 19:12:20 Yes I mean PPAPI plugins. I changed the comment to
Lei Zhang 2017/07/12 22:57:30 So what was wrong with my initial suggestion?
tommycli 2017/07/12 23:05:15 I suggested the new version and did not see your o
amberwon 2017/07/13 20:33:54 Done.
+// disabled and user clicks to view PDF.
+IPC_MESSAGE_ROUTED1(ChromeViewHostMsg_OpenPDF, GURL /* url */)

Powered by Google App Engine
This is Rietveld 408576698