Click to Open PDF: Open PDF once View PDF is clicked.

chrome/browser/plugins/plugin_observer.cc

Index: chrome/browser/plugins/plugin_observer.cc
diff --git a/chrome/browser/plugins/plugin_observer.cc b/chrome/browser/plugins/plugin_observer.cc
index 6f939ac790ca9b8ad9b3fabee2019b5bf5470162..878d5e17bb96d085ee2729b7a7d1ea6c62d8b002 100644
--- a/chrome/browser/plugins/plugin_observer.cc
+++ b/chrome/browser/plugins/plugin_observer.cc
@@ -267,6 +267,7 @@ bool PluginObserver::OnMessageReceived(
                         OnShowFlashPermissionBubble)
     IPC_MESSAGE_HANDLER(ChromeViewHostMsg_CouldNotLoadPlugin,
                         OnCouldNotLoadPlugin)
+    IPC_MESSAGE_HANDLER(ChromeViewHostMsg_OpenPDF, OnOpenPDF)
 
     IPC_MESSAGE_UNHANDLED(return false)
   IPC_END_MESSAGE_MAP()
@@ -335,3 +336,13 @@ void PluginObserver::OnCouldNotLoadPlugin(const base::FilePath& plugin_path) {
                                  plugin_name),
       true);
 }
+
+void PluginObserver::OnOpenPDF(const GURL& url) {
+  web_contents()->OpenURL(content::OpenURLParams(
+      url,
+      content::Referrer::SanitizeForRequest(
+          url, content::Referrer(web_contents()->GetURL(),
+                                 blink::kWebReferrerPolicyDefault)),
+      WindowOpenDisposition::NEW_FOREGROUND_TAB,
+      ui::PAGE_TRANSITION_AUTO_BOOKMARK, false));

[Lei Zhang, 2017/07/07 22:47:58]

I'm not sure if these are correct, but I also don't know the right answers. Can
you explain why you chose PAGE_TRANSITION_AUTO_BOOKMARK, and
is_renderer_initiated = false?

[amberwon, 2017/07/11 18:08:05]

They were used for OnOpenAboutPlugins, when the placeholder for PDF's showed a
link to chrome://plugins. So I chose them again here.
PAGE_TRANSITION_AUTO_BOOKMARK means that the user got to this page through a
suggestion in the UI.
is_renderer_initiated indicates whether the navigation is initiated by the
renderer process. In this case, the browser process initiates it.

[Lei Zhang, 2017/07/12 00:51:37]

Well, since the code being referred to was removed in https://crrev.com/443581,
I'll add dcheng@ as the security reviewer for this CL. Some of the code looks
familiar, but there is the addition of a GURL parameter.

+}