chrome/common/render_messages.h - Issue 2972123002: Click to Open PDF: Open PDF once View PDF is clicked.

Side by Side Diff: chrome/common/render_messages.h

Issue 2972123002: Click to Open PDF: Open PDF once View PDF is clicked. (Closed)

Patch Set: Rename from download to open PDF Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // Multiply-included file, no traditional include guard.	5 // Multiply-included file, no traditional include guard.

6 #include <stdint.h>	6 #include <stdint.h>

7 #include <string>	7 #include <string>

8 #include <vector>	8 #include <vector>

9	9

10 #include "base/files/file_path.h"	10 #include "base/files/file_path.h"

(...skipping 323 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
334 // process so that they can be assigned to an Instant renderer.	334 // process so that they can be assigned to an Instant renderer.

335 IPC_MESSAGE_CONTROL2(ChromeViewMsg_SetSearchURLs,	335 IPC_MESSAGE_CONTROL2(ChromeViewMsg_SetSearchURLs,

336 std::vector<GURL> /* search_urls */,	336 std::vector<GURL> /* search_urls */,

337 GURL /* new_tab_page_url */)	337 GURL /* new_tab_page_url */)

338	338

339 #if BUILDFLAG(ENABLE_PLUGINS)	339 #if BUILDFLAG(ENABLE_PLUGINS)

340 // Sent by the renderer to check if crash reporting is enabled.	340 // Sent by the renderer to check if crash reporting is enabled.

341 IPC_SYNC_MESSAGE_CONTROL0_1(ChromeViewHostMsg_IsCrashReportingEnabled,	341 IPC_SYNC_MESSAGE_CONTROL0_1(ChromeViewHostMsg_IsCrashReportingEnabled,

342 bool /* enabled */)	342 bool /* enabled */)

343 #endif	343 #endif

	344

	345 // Tells the browser to open a PDF file in a new tab. Used when plugins are
	Lei Zhang 2017/07/07 22:47:58 plugins are disabled -> there is no PDF viewer ava plugins are disabled -> there is no PDF viewer available ? amberwon 2017/07/11 18:08:05 I believe just Chrome's PDF Viewer is disabled, bu Show quoted text On 2017/07/07 22:47:58, Lei Zhang wrote: > plugins are disabled -> there is no PDF viewer available ? I believe just Chrome's PDF Viewer is disabled, but other PDF viewers may be available. Lei Zhang 2017/07/12 00:51:37 If one disables the internal PDF Viewer and instal Show quoted text On 2017/07/11 18:08:05, amberwon wrote: > On 2017/07/07 22:47:58, Lei Zhang wrote: > > plugins are disabled -> there is no PDF viewer available ? > > I believe just Chrome's PDF Viewer is disabled, but other PDF > viewers may be available. If one disables the internal PDF Viewer and installs a Rob's PDF Viewer extension, [1] then a page that embeds a PDF will still display the PDF, and the pdf_plugin.html placeholder won't show. By plugins, do you really mean PPAPI plugins, or just anything that can be plugged in, which includes extensions? [1] https://chrome.google.com/webstore/detail/pdf-viewer/oemmndcbldboiebfnladdacb... amberwon 2017/07/12 19:12:20 Yes I mean PPAPI plugins. I changed the comment to Show quoted text On 2017/07/12 00:51:37, Lei Zhang wrote: > On 2017/07/11 18:08:05, amberwon wrote: > > On 2017/07/07 22:47:58, Lei Zhang wrote: > > > plugins are disabled -> there is no PDF viewer available ? > > > > I believe just Chrome's PDF Viewer is disabled, but other PDF > > viewers may be available. > > If one disables the internal PDF Viewer and installs a Rob's PDF Viewer > extension, [1] then a page that embeds a PDF will still display the PDF, and the > pdf_plugin.html placeholder won't show. > > By plugins, do you really mean PPAPI plugins, or just anything that can be > plugged in, which includes extensions? > > [1] > https://chrome.google.com/webstore/detail/pdf-viewer/oemmndcbldboiebfnladdacb... Yes I mean PPAPI plugins. I changed the comment to reflect the case where a user has an PDF viewer extension as well. Lei Zhang 2017/07/12 22:57:30 So what was wrong with my initial suggestion? Show quoted text On 2017/07/12 19:12:20, amberwon wrote: > On 2017/07/12 00:51:37, Lei Zhang wrote: > > On 2017/07/11 18:08:05, amberwon wrote: > > > On 2017/07/07 22:47:58, Lei Zhang wrote: > > > > plugins are disabled -> there is no PDF viewer available ? > > > > > > I believe just Chrome's PDF Viewer is disabled, but other PDF > > > viewers may be available. > > > > If one disables the internal PDF Viewer and installs a Rob's PDF Viewer > > extension, [1] then a page that embeds a PDF will still display the PDF, and > the > > pdf_plugin.html placeholder won't show. > > > > By plugins, do you really mean PPAPI plugins, or just anything that can be > > plugged in, which includes extensions? > > > > [1] > > > https://chrome.google.com/webstore/detail/pdf-viewer/oemmndcbldboiebfnladdacb... > > Yes I mean PPAPI plugins. I changed the comment to reflect the case where a user > has an PDF viewer extension as well. So what was wrong with my initial suggestion? tommycli 2017/07/12 23:05:15 I suggested the new version and did not see your o Show quoted text On 2017/07/12 22:57:30, Lei Zhang wrote: > On 2017/07/12 19:12:20, amberwon wrote: > > On 2017/07/12 00:51:37, Lei Zhang wrote: > > > On 2017/07/11 18:08:05, amberwon wrote: > > > > On 2017/07/07 22:47:58, Lei Zhang wrote: > > > > > plugins are disabled -> there is no PDF viewer available ? > > > > > > > > I believe just Chrome's PDF Viewer is disabled, but other PDF > > > > viewers may be available. > > > > > > If one disables the internal PDF Viewer and installs a Rob's PDF Viewer > > > extension, [1] then a page that embeds a PDF will still display the PDF, and > > the > > > pdf_plugin.html placeholder won't show. > > > > > > By plugins, do you really mean PPAPI plugins, or just anything that can be > > > plugged in, which includes extensions? > > > > > > [1] > > > > > > https://chrome.google.com/webstore/detail/pdf-viewer/oemmndcbldboiebfnladdacb... > > > > Yes I mean PPAPI plugins. I changed the comment to reflect the case where a > user > > has an PDF viewer extension as well. > > So what was wrong with my initial suggestion? I suggested the new version and did not see your original suggestion. The original suggestion seems just fine as well and probably more concise. amberwon 2017/07/13 20:33:54 Done. Show quoted text On 2017/07/12 22:57:30, Lei Zhang (OOO) wrote: > On 2017/07/12 19:12:20, amberwon wrote: > > On 2017/07/12 00:51:37, Lei Zhang wrote: > > > On 2017/07/11 18:08:05, amberwon wrote: > > > > On 2017/07/07 22:47:58, Lei Zhang wrote: > > > > > plugins are disabled -> there is no PDF viewer available ? > > > > > > > > I believe just Chrome's PDF Viewer is disabled, but other PDF > > > > viewers may be available. > > > > > > If one disables the internal PDF Viewer and installs a Rob's PDF Viewer > > > extension, [1] then a page that embeds a PDF will still display the PDF, and > > the > > > pdf_plugin.html placeholder won't show. > > > > > > By plugins, do you really mean PPAPI plugins, or just anything that can be > > > plugged in, which includes extensions? > > > > > > [1] > > > > > > https://chrome.google.com/webstore/detail/pdf-viewer/oemmndcbldboiebfnladdacb... > > > > Yes I mean PPAPI plugins. I changed the comment to reflect the case where a > user > > has an PDF viewer extension as well. > > So what was wrong with my initial suggestion? Done.
	346 // disabled and user clicks to view PDF.

	347 IPC_MESSAGE_ROUTED1(ChromeViewHostMsg_OpenPDF, GURL /* url */)

OLD	NEW

« chrome/browser/plugins/plugin_observer.cc ('K') | « chrome/browser/plugins/plugin_observer.cc ('k') | chrome/renderer/plugins/pdf_plugin_placeholder.h » ('j') | no next file with comments »