Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Issue 2971613002: Add command-line flag to force compositor framerate. (Closed)

Created:
3 years, 5 months ago by jbauman
Modified:
3 years, 5 months ago
Reviewers:
danakj, piman
CC:
chromium-reviews, Ian Vollick, jbauman+watch_chromium.org, piman+watch_chromium.org, kalyank, danakj+watch_chromium.org, cc-bugs_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add command-line flag to force compositor framerate. This allows us to test how power consumption is affected by reducing the framerate. Review-Url: https://codereview.chromium.org/2971613002 Cr-Commit-Position: refs/heads/master@{#485128} Committed: https://chromium.googlesource.com/chromium/src/+/f52e41c6e9a3f2d2c80eec12d30a308f6f8b225b

Patch Set 1 #

Patch Set 2 : minor fix #

Patch Set 3 : change flag name to limit-fps #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M ui/compositor/compositor.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/compositor/compositor.cc View 1 2 3 chunks +14 lines, -0 lines 0 comments Download
M ui/compositor/compositor_switches.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ui/compositor/compositor_switches.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 28 (19 generated)
jbauman
3 years, 5 months ago (2017-07-06 01:03:11 UTC) #9
danakj
Drive-by LGTM to suggest limit-fps instead of force-fps, as it's a cap.
3 years, 5 months ago (2017-07-06 14:43:36 UTC) #13
piman
lgtm
3 years, 5 months ago (2017-07-06 17:28:08 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2971613002/40001
3 years, 5 months ago (2017-07-06 21:24:41 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, build has not started yet; ...
3 years, 5 months ago (2017-07-06 21:56:46 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2971613002/40001
3 years, 5 months ago (2017-07-06 22:48:25 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/422641)
3 years, 5 months ago (2017-07-06 23:33:06 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2971613002/40001
3 years, 5 months ago (2017-07-08 00:58:50 UTC) #25
commit-bot: I haz the power
3 years, 5 months ago (2017-07-08 02:06:10 UTC) #28
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f52e41c6e9a3f2d2c80eec12d30a...

Powered by Google App Engine
This is Rietveld 408576698