Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2971113002:
[ios] Plumb SnapshotCache into tab grid. (Closed)
Description[ios] Plumb SnapshotCache into tab grid.
BUG=686770
Review-Url: https://codereview.chromium.org/2971113002
Cr-Commit-Position: refs/heads/master@{#485145}
Committed: https://chromium.googlesource.com/chromium/src/+/4abe4b623c2d4e922812208f7c856536daed30c7
Patch Set 1 #
Total comments: 4
Patch Set 2 : Address comments. #
Dependent Patchsets: Messages
Total messages: 30 (21 generated)
Description was changed from ========== [ios] Plumb SnapshotCache into tab grid. BUG= ========== to ========== [ios] Plumb SnapshotCache into tab grid. BUG=686770 ==========
The CQ bit was checked by edchin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
edchin@chromium.org changed reviewers: + jif@chromium.org, marq@chromium.org, rohitrao@chromium.org, sczs@chromium.org
PTAL.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2971113002/diff/1/ios/clean/chrome/browser/ui... File ios/clean/chrome/browser/ui/tab_collection/tab_collection_view_controller.h (right): https://codereview.chromium.org/2971113002/diff/1/ios/clean/chrome/browser/ui... ios/clean/chrome/browser/ui/tab_collection/tab_collection_view_controller.h:26: @property(nonatomic, strong) SnapshotCache* snapshotCache; Does the view controller need a strong reference to the cache? It doesn't own it, right? https://codereview.chromium.org/2971113002/diff/1/ios/clean/chrome/browser/ui... File ios/clean/chrome/browser/ui/tab_grid/tab_grid_coordinator.mm (right): https://codereview.chromium.org/2971113002/diff/1/ios/clean/chrome/browser/ui... ios/clean/chrome/browser/ui/tab_grid/tab_grid_coordinator.mm:298: - (SnapshotCache*)snapshotCache { This feels like it should be a readonly property.
lgtm
PTAL. Comments addressed. https://codereview.chromium.org/2971113002/diff/1/ios/clean/chrome/browser/ui... File ios/clean/chrome/browser/ui/tab_collection/tab_collection_view_controller.h (right): https://codereview.chromium.org/2971113002/diff/1/ios/clean/chrome/browser/ui... ios/clean/chrome/browser/ui/tab_collection/tab_collection_view_controller.h:26: @property(nonatomic, strong) SnapshotCache* snapshotCache; On 2017/07/06 12:44:49, marq (ping after 24h) wrote: > Does the view controller need a strong reference to the cache? It doesn't own > it, right? Done. https://codereview.chromium.org/2971113002/diff/1/ios/clean/chrome/browser/ui... File ios/clean/chrome/browser/ui/tab_grid/tab_grid_coordinator.mm (right): https://codereview.chromium.org/2971113002/diff/1/ios/clean/chrome/browser/ui... ios/clean/chrome/browser/ui/tab_grid/tab_grid_coordinator.mm:298: - (SnapshotCache*)snapshotCache { On 2017/07/06 12:44:50, marq (ping after 24h) wrote: > This feels like it should be a readonly property. Done.
lgtm
The CQ bit was checked by edchin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
Patchset #4 (id:60001) has been deleted
Patchset #3 (id:40001) has been deleted
Patchset #2 (id:20001) has been deleted
The CQ bit was checked by edchin@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jif@chromium.org, marq@chromium.org Link to the patchset: https://codereview.chromium.org/2971113002/#ps80001 (title: "Address comments.")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
The CQ bit was checked by edchin@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jif@chromium.org, marq@chromium.org Link to the patchset: https://codereview.chromium.org/2971113002/#ps100001 (title: "Missing dependency.")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #2 (id:80001) has been deleted
CQ is committing da patch.
Bot data: {"patchset_id": 100001, "attempt_start_ts": 1499499542552680,
"parent_rev": "6b409cea68367a4e33effaea004d044bff712689", "commit_rev":
"4abe4b623c2d4e922812208f7c856536daed30c7"}
Message was sent while issue was closed.
Description was changed from ========== [ios] Plumb SnapshotCache into tab grid. BUG=686770 ========== to ========== [ios] Plumb SnapshotCache into tab grid. BUG=686770 Review-Url: https://codereview.chromium.org/2971113002 Cr-Commit-Position: refs/heads/master@{#485145} Committed: https://chromium.googlesource.com/chromium/src/+/4abe4b623c2d4e922812208f7c85... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:100001) as https://chromium.googlesource.com/chromium/src/+/4abe4b623c2d4e922812208f7c85... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
