ios/clean/chrome/browser/ui/tab_collection/tab_collection_view_controller.mm - Issue 2971113002: [ios] Plumb SnapshotCache into tab grid.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/clean/chrome/browser/ui/tab_collection/tab_collection_view_controller.mm

Issue 2971113002: [ios] Plumb SnapshotCache into tab grid. (Closed)

Patch Set: Address comments. Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ios/clean/chrome/browser/ui/tab_collection/tab_collection_view_controller.h ('k') | ios/clean/chrome/browser/ui/tab_grid/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/clean/chrome/browser/ui/tab_collection/tab_collection_view_controller.mm

diff --git a/ios/clean/chrome/browser/ui/tab_collection/tab_collection_view_controller.mm b/ios/clean/chrome/browser/ui/tab_collection/tab_collection_view_controller.mm

index 9b413be4cb2a283fa4de8c5ddd996ebf5646499d..87b9107604610f89762c285bbb91c8ef0dd46387 100644

--- a/ios/clean/chrome/browser/ui/tab_collection/tab_collection_view_controller.mm

+++ b/ios/clean/chrome/browser/ui/tab_collection/tab_collection_view_controller.mm

@@ -28,6 +28,7 @@

@synthesize tabs = _tabs;

@synthesize items = _items;

@synthesize selectedIndex = _selectedIndex;

+@synthesize snapshotCache = _snapshotCache;

#pragma mark - UIViewController

@@ -118,8 +119,7 @@

[cell setSessionType:TabSwitcherSessionType::REGULAR_SESSION];

DCHECK_LE(indexPath.item, INT_MAX);

int index = static_cast<int>(indexPath.item);

- // PLACEHOLDER: SnapshotCache will be passed into the cell.

- [cell configureCell:self.items[index] snapshotCache:nil];

+ [cell configureCell:self.items[index] snapshotCache:self.snapshotCache];

return cell;

}

@@ -194,8 +194,7 @@

TabCollectionTabCell* cell = base::mac::ObjCCastStrict<TabCollectionTabCell>(

[self.tabs cellForItemAtIndexPath:[NSIndexPath indexPathForItem:index

inSection:0]]);

- // PLACEHOLDER: SnapshotCache will be passed into the cell.

- [cell configureCell:self.items[index] snapshotCache:nil];

+ [cell configureCell:self.items[index] snapshotCache:self.snapshotCache];

}

- (void)populateItems:(NSArray<TabCollectionItem*>*)items