Issue 2970953003: Use entities in ParameterTypeInformation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2970953003: Use entities in ParameterTypeInformation (Closed)

Created:
3 years, 5 months ago by Johnni Winther

Modified:
3 years, 5 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 3 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -44 lines)			Patch
M	pkg/compiler/lib/src/inferrer/node_tracer.dart	View	1 2	2 chunks	+3 lines, -3 lines	0 comments	Download
M	pkg/compiler/lib/src/inferrer/type_graph_nodes.dart	View	1 2	4 chunks	+23 lines, -13 lines	0 comments	Download
M	pkg/compiler/lib/src/inferrer/type_system.dart	View	1 2	1 chunk	+9 lines, -2 lines	0 comments	Download
M	pkg/compiler/lib/src/js_backend/backend.dart	View	1 2	2 chunks	+11 lines, -8 lines	0 comments	Download
M	pkg/compiler/lib/src/js_backend/mirrors_data.dart	View	1 2	2 chunks	+0 lines, -18 lines	0 comments	Download

Total messages: 5 (2 generated)

Siggi Cherem (dart-lang)

lgtm (second patch was missing the diff-base, so I focused on patchset #2 + changes ...

3 years, 5 months ago (2017-07-05 21:12:15 UTC) #3

Johnni Winther

3 years, 5 months ago (2017-07-06 10:31:13 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
f32dbe2d27762fa1965f585f782775c7e1b5b8c7 (presubmit successful).