Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: pkg/compiler/lib/src/js_backend/mirrors_data.dart

Issue 2970953003: Use entities in ParameterTypeInformation (Closed)
Patch Set: Fix Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/js_backend/backend.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/js_backend/mirrors_data.dart
diff --git a/pkg/compiler/lib/src/js_backend/mirrors_data.dart b/pkg/compiler/lib/src/js_backend/mirrors_data.dart
index 55a450fafef819551e06e51d53b98df1a62ec447..65222f7f70223453c76f2c583d0d589e19be4dca 100644
--- a/pkg/compiler/lib/src/js_backend/mirrors_data.dart
+++ b/pkg/compiler/lib/src/js_backend/mirrors_data.dart
@@ -131,8 +131,6 @@ abstract class MirrorsData {
bool retainMetadataOfMember(covariant MemberEntity element);
bool retainMetadataOfParameter(ParameterElement element);
- bool invokedReflectively(Element element);
-
/// Returns true if this element has to be enqueued due to
/// mirror usage. Might be a subset of [referencedFromMirrorSystem] if
/// normal tree shaking is still active ([isTreeShakingDisabled] is false).
@@ -314,22 +312,6 @@ class MirrorsDataImpl implements MirrorsData, MirrorsDataBuilder {
}
}
- bool invokedReflectively(Element element) {
- if (element.isParameter) {
- ParameterElement parameter = element;
- if (invokedReflectively(parameter.functionDeclaration)) return true;
- }
-
- if (element.isField) {
- if (Elements.isStaticOrTopLevel(element) &&
- (element.isFinal || element.isConst)) {
- return false;
- }
- }
-
- return isAccessibleByReflection(element.declaration);
- }
-
/// Sets of elements that are needed by reflection. Computed using
/// [computeMembersNeededForReflection] on first use.
Set<ClassElement> _classesNeededForReflection;
« no previous file with comments | « pkg/compiler/lib/src/js_backend/backend.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698