Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Unified Diff: pkg/compiler/lib/src/inferrer/type_system.dart

Issue 2970953003: Use entities in ParameterTypeInformation (Closed)
Patch Set: Fix Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/inferrer/type_graph_nodes.dart ('k') | pkg/compiler/lib/src/js_backend/backend.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/inferrer/type_system.dart
diff --git a/pkg/compiler/lib/src/inferrer/type_system.dart b/pkg/compiler/lib/src/inferrer/type_system.dart
index debbb4de1776847dd94a0c403f55d661ca7dae86..74f42cd74e23751bf14f0aea09fc9b4db44af3ba 100644
--- a/pkg/compiler/lib/src/inferrer/type_system.dart
+++ b/pkg/compiler/lib/src/inferrer/type_system.dart
@@ -345,18 +345,25 @@ class TypeSystem {
LocalFunctionElement localFunction = parameter.functionDeclaration;
MethodElement callMethod = localFunction.callMethod;
return new ParameterTypeInformation.localFunction(
- getInferredTypeOfMember(callMethod), parameter, callMethod);
+ getInferredTypeOfMember(callMethod),
+ parameter,
+ parameter.type,
+ callMethod);
} else if (parameter.functionDeclaration.isInstanceMember) {
MethodElement method = parameter.functionDeclaration;
return new ParameterTypeInformation.instanceMember(
getInferredTypeOfMember(method),
parameter,
+ parameter.type,
method,
new ParameterAssignments());
} else {
MethodElement method = parameter.functionDeclaration;
return new ParameterTypeInformation.static(
- getInferredTypeOfMember(method), parameter, method);
+ getInferredTypeOfMember(method), parameter, parameter.type, method,
+ // TODO(johnniwinther): Is this still valid now that initializing
+ // formals also introduce locals?
+ isInitializingFormal: parameter.isInitializingFormal);
}
}
« no previous file with comments | « pkg/compiler/lib/src/inferrer/type_graph_nodes.dart ('k') | pkg/compiler/lib/src/js_backend/backend.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698