Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 2970663002: Revert of [turbofan] Extend escape analysis to reduce certain CheckMaps. (Closed)

Created:
3 years, 5 months ago by Benedikt Meurer
Modified:
3 years, 5 months ago
Reviewers:
Tobias Tebbi
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [turbofan] Extend escape analysis to reduce certain CheckMaps. (patchset #1 id:1 of https://codereview.chromium.org/2964473002/ ) Reason for revert: Speculative revert for tiny fire on Canary (crbug.com/738781) Original issue's description: > [turbofan] Extend escape analysis to reduce certain CheckMaps. > > Enable the experimental support in escape analysis to deal with > constant-foldable CheckMaps nodes and remove them from the effect > chain w/o blocking the scalar replacement of the object. > > BUG=v8:4586, v8:5267 > R=tebbi@chromium.org > > Review-Url: https://codereview.chromium.org/2964473002 > Cr-Commit-Position: refs/heads/master@{#46311} > Committed: https://chromium.googlesource.com/v8/v8/+/adf7f54e24c4b31207b4df0e30c28f7579b18f5c TBR=tebbi@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=v8:4586, v8:5267 Review-Url: https://codereview.chromium.org/2970663002 Cr-Commit-Position: refs/heads/master@{#46372} Committed: https://chromium.googlesource.com/v8/v8/+/9e7b928f0f8be2de8f63424f9adb31cf52f3be81

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -23 lines) Patch
M src/compiler/escape-analysis.cc View 1 chunk +26 lines, -23 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Benedikt Meurer
Created Revert of [turbofan] Extend escape analysis to reduce certain CheckMaps.
3 years, 5 months ago (2017-07-03 07:13:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2970663002/1
3 years, 5 months ago (2017-07-03 07:13:30 UTC) #3
commit-bot: I haz the power
3 years, 5 months ago (2017-07-03 07:39:41 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/9e7b928f0f8be2de8f63424f9adb31cf52f...

Powered by Google App Engine
This is Rietveld 408576698