Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 2964473002: [turbofan] Extend escape analysis to reduce certain CheckMaps. (Closed)

Created:
3 years, 5 months ago by Benedikt Meurer
Modified:
3 years, 5 months ago
Reviewers:
Tobias Tebbi
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Extend escape analysis to reduce certain CheckMaps. Enable the experimental support in escape analysis to deal with constant-foldable CheckMaps nodes and remove them from the effect chain w/o blocking the scalar replacement of the object. BUG=v8:4586, v8:5267 R=tebbi@chromium.org Review-Url: https://codereview.chromium.org/2964473002 Cr-Commit-Position: refs/heads/master@{#46311} Committed: https://chromium.googlesource.com/v8/v8/+/adf7f54e24c4b31207b4df0e30c28f7579b18f5c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -25 lines) Patch
M src/compiler/escape-analysis.cc View 1 chunk +22 lines, -25 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Benedikt Meurer
3 years, 5 months ago (2017-06-29 09:34:00 UTC) #1
Tobias Tebbi
On 2017/06/29 09:34:00, Benedikt Meurer wrote: LGTM
3 years, 5 months ago (2017-06-29 09:43:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2964473002/1
3 years, 5 months ago (2017-06-29 09:43:28 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/adf7f54e24c4b31207b4df0e30c28f7579b18f5c
3 years, 5 months ago (2017-06-29 10:18:28 UTC) #10
Benedikt Meurer
3 years, 5 months ago (2017-07-03 07:13:20 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2970663002/ by bmeurer@chromium.org.

The reason for reverting is: Speculative revert for tiny fire on Canary
(crbug.com/738781).

Powered by Google App Engine
This is Rietveld 408576698