Add generic text printing

Add generic text printing

Depends on https://pdfium-review.googlesource.com/c/7194

BUG=734850
Review-Url: https://codereview.chromium.org/2970473002
Cr-Commit-Position: refs/heads/master@{#486892}
Committed: https://chromium.googlesource.com/chromium/src/+/0437a171a47da67fc40a154dc26bcab9fae8bc25

[rbpotter, 2017-07-01 00:33:44]

Description was changed from

==========
Add generic text printing

BUG=734850
==========

to

==========
Add generic text printing

Depends on https://pdfium-review.googlesource.com/c/7194

BUG=734850
==========

[rbpotter, 2017-07-01 00:33:45]

rbpotter@chromium.org changed reviewers:
+ thestig@chromium.org

[rbpotter, 2017-07-01 00:42:07]

Think this (and the pdfium patch linked) are ready for an
initial look - let me know if this seems like a reasonable
approach and/or something we would want to do. Seems to
work on the ZPL examples I have so far as well as text only
pages. Formatted web pages - all the text ends up in the
output, but ordering can be odd since it depends on the
order PDFium reads the text objects in.

[Lei Zhang, 2017-07-05 23:27:08]

Having a combined FPDF_SetPrintMode() may help reduce the amount of plumbing
necessary here.

https://codereview.chromium.org/2970473002/diff/20001/chrome/utility/printing...
File chrome/utility/printing_handler.cc (right):

https://codereview.chromium.org/2970473002/diff/20001/chrome/utility/printing...
chrome/utility/printing_handler.cc:125: pdf_rendering_settings_.mode ==
PdfRenderSettings::Mode::TEXTONLY;
TEXTONLY is postscript?

https://codereview.chromium.org/2970473002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/LayoutTableBoxComponent.cpp (right):

https://codereview.chromium.org/2970473002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/LayoutTableBoxComponent.cpp:45: //
DCHECK_EQ(layout_object_.GetDocument().Lifecycle().GetState(),
Accidental upload?

If DCHECKs are failing unexpectedly, that's a bug...

[rbpotter, 2017-07-06 01:31:17]

https://codereview.chromium.org/2970473002/diff/20001/chrome/utility/printing...
File chrome/utility/printing_handler.cc (right):

https://codereview.chromium.org/2970473002/diff/20001/chrome/utility/printing...
chrome/utility/printing_handler.cc:125: pdf_rendering_settings_.mode ==
PdfRenderSettings::Mode::TEXTONLY;
On 2017/07/05 23:27:08, Lei Zhang wrote:
> TEXTONLY is postscript?

Did this initially to avoid scaling the DC, but then updated the
pdfium side to ignore the DC size entirely and forgot to remove it.

https://codereview.chromium.org/2970473002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/LayoutTableBoxComponent.cpp (right):

https://codereview.chromium.org/2970473002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/LayoutTableBoxComponent.cpp:45: //
DCHECK_EQ(layout_object_.GetDocument().Lifecycle().GetState(),
On 2017/07/05 23:27:08, Lei Zhang wrote:
> Accidental upload?
> 
> If DCHECKs are failing unexpectedly, that's a bug...

This DCHECK was failing on clean builds as well on certain pages.
I got annoyed with it crashing any print preview of a Wikipedia page
so removed it in all my local branches.

[Lei Zhang, 2017-07-12 00:21:15]

https://codereview.chromium.org/2970473002/diff/60001/chrome/utility/printing...
File chrome/utility/printing_handler.cc (right):

https://codereview.chromium.org/2970473002/diff/60001/chrome/utility/printing...
chrome/utility/printing_handler.cc:97: printing_mode = 1;
If you add another enum in pdf/pdf.h and change SetPDFUsePrintMode() to use that
enum as its parameter, then you can use those enum values here instead of these
magical values. Inside pdf/pdfium, you can static_assert() those enum values
match up with FPDF_PRINTMODE_* from PDFium.

Previously, having postscript_level = 2 made sense without needing an enum.

[rbpotter, 2017-07-13 18:46:04]

The CQ bit was checked by rbpotter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-13 18:46:11]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rbpotter, 2017-07-13 18:46:15]

https://codereview.chromium.org/2970473002/diff/60001/chrome/utility/printing...
File chrome/utility/printing_handler.cc (right):

https://codereview.chromium.org/2970473002/diff/60001/chrome/utility/printing...
chrome/utility/printing_handler.cc:97: printing_mode = 1;
On 2017/07/12 00:21:15, Lei Zhang (OOO) wrote:
> If you add another enum in pdf/pdf.h and change SetPDFUsePrintMode() to use
that
> enum as its parameter, then you can use those enum values here instead of
these
> magical values. Inside pdf/pdfium, you can static_assert() those enum values
> match up with FPDF_PRINTMODE_* from PDFium.
> 
> Previously, having postscript_level = 2 made sense without needing an enum.

Done.

[commit-bot: I haz the power, 2017-07-13 19:01:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-13 19:01:30]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[Lei Zhang, 2017-07-13 20:53:16]

lgtm

https://codereview.chromium.org/2970473002/diff/80001/pdf/pdf.h
File pdf/pdf.h (right):

https://codereview.chromium.org/2970473002/diff/80001/pdf/pdf.h#newcode41
pdf/pdf.h:41: EMF = 0,
Switch to kFoo for new enums?

[rbpotter, 2017-07-14 01:11:34]

The CQ bit was checked by rbpotter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-14 01:11:57]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-14 02:52:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-14 02:52:22]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[rbpotter, 2017-07-14 21:18:23]

The CQ bit was checked by rbpotter@chromium.org

[rbpotter, 2017-07-14 21:18:24]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/2970473002/#ps100001
(title: "Change enum names")

[commit-bot: I haz the power, 2017-07-14 21:18:44]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-14 21:23:26]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1500067103332150,
"parent_rev": "2802973e5d90d2da902b44cf614bfe9f94bb6b0a", "commit_rev":
"dd01a12cb5599dae010e612c6bf95857580c571c"}

[commit-bot: I haz the power, 2017-07-14 21:23:44]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1500067103332150,
"parent_rev": "4272e0fd06fa417c03289344a49c75054ea4b5f1", "commit_rev":
"0437a171a47da67fc40a154dc26bcab9fae8bc25"}

[commit-bot: I haz the power, 2017-07-14 21:24:03]

Description was changed from

==========
Add generic text printing

Depends on https://pdfium-review.googlesource.com/c/7194

BUG=734850
==========

to

==========
Add generic text printing

Depends on https://pdfium-review.googlesource.com/c/7194

BUG=734850

Review-Url: https://codereview.chromium.org/2970473002
Cr-Commit-Position: refs/heads/master@{#486892}
Committed:
https://chromium.googlesource.com/chromium/src/+/0437a171a47da67fc40a154dc26b...
==========

[commit-bot: I haz the power, 2017-07-14 21:24:04]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/0437a171a47da67fc40a154dc26b...