Add generic text printing

third_party/WebKit/Source/core/layout/LayoutTableBoxComponent.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/layout/LayoutTableBoxComponent.h"
 
 #include "core/layout/LayoutTable.h"
 #include "core/paint/ObjectPaintInvalidator.h"
 #include "core/style/ComputedStyle.h"
 
@@ skipping 24 matching lines @@
   // optimization but now it seems that diff.needsFullLayout() implies
   // tablePart.needsLayout().
   return diff.NeedsFullLayout() && table_part.NeedsLayout() &&
          table.ShouldCollapseBorders() &&
          !old_style.BorderSizeEquals(*table_part.Style());
 }
 
 void LayoutTableBoxComponent::MutableForPainting::UpdatePaintResult(
     PaintResult paint_result,
     const CullRect& paint_rect) {
-  DCHECK_EQ(layout_object_.GetDocument().Lifecycle().GetState(),
-            DocumentLifecycle::LifecycleState::kInPaint);
+  // DCHECK_EQ(layout_object_.GetDocument().Lifecycle().GetState(),

[Lei Zhang, 2017/07/05 23:27:08]

Accidental upload?

If DCHECKs are failing unexpectedly, that's a bug...

[rbpotter, 2017/07/06 01:31:17]

This DCHECK was failing on clean builds as well on certain pages.
I got annoyed with it crashing any print preview of a Wikipedia page
so removed it in all my local branches.

+  //          DocumentLifecycle::LifecycleState::kInPaint);
 
   // A table row or section may paint large background display item which
   // contains paint operations of the background in each contained cell.
   // The display item can be clipped by the paint rect to avoid painting
   // on areas not interested. If we didn't fully paint and paint rect changes,
   // we need to invalidate the display item (using setDisplayItemUncached()
   // because we are already in painting.)
   auto& box = static_cast<LayoutTableBoxComponent&>(layout_object_);
   if (box.last_paint_result_ != kFullyPainted &&
       box.last_paint_rect_ != paint_rect)
     layout_object_.SetDisplayItemsUncached();
 
   box.last_paint_result_ = paint_result;
   box.last_paint_rect_ = paint_rect;
 }
 
 }  // namespace blink