Add variations filtering for is_low_end_device.

Add variations filtering for is_low_end_device.

This will allow studies to target low end devices only.

BUG=738153
Review-Url: https://codereview.chromium.org/2970093002
Cr-Commit-Position: refs/heads/master@{#485713}
Committed: https://chromium.googlesource.com/chromium/src/+/a91d3fbb37384c053ac2d092534b42e048661fb8

[Alexei Svitkine (slow), 2017-07-05 17:58:21]

The CQ bit was checked by asvitkine@chromium.org to run a CQ dry run

[Alexei Svitkine (slow), 2017-07-05 17:58:22]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2017-07-05 17:58:39]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Alexei Svitkine (slow), 2017-07-05 17:59:14]

asvitkine@chromium.org changed reviewers:
+ mariakhomenko@chromium.org, rkaplow@chromium.org

[commit-bot: I haz the power, 2017-07-05 18:22:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-05 18:22:26]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[rkaplow, 2017-07-06 17:49:49]

lgtm

https://codereview.chromium.org/2970093002/diff/20001/components/variations/c...
File components/variations/client_filterable_state.h (right):

https://codereview.chromium.org/2970093002/diff/20001/components/variations/c...
components/variations/client_filterable_state.h:43: 
can you link to the definition of this somewhere? I feel some docs are helpful
since the definition of a low end device which change from year to year

https://codereview.chromium.org/2970093002/diff/20001/components/variations/s...
File components/variations/study_filtering_unittest.cc (right):

https://codereview.chromium.org/2970093002/diff/20001/components/variations/s...
components/variations/study_filtering_unittest.cc:261: // Check that if the
filter is not set, study applies to either low end.
nit - "either low end setting"? Current wording seems awkward

[Maria, 2017-07-11 03:52:08]

lgtm

Thanks!

[Alexei Svitkine (slow), 2017-07-11 15:08:14]

https://codereview.chromium.org/2970093002/diff/20001/components/variations/c...
File components/variations/client_filterable_state.h (right):

https://codereview.chromium.org/2970093002/diff/20001/components/variations/c...
components/variations/client_filterable_state.h:43: 
On 2017/07/06 17:49:49, rkaplow wrote:
> can you link to the definition of this somewhere? I feel some docs are helpful
> since the definition of a low end device which change from year to year

Done.

Mentioned base::SysInfo::IsLowEndDevice() where this comes from. The docs for
that have details.

https://codereview.chromium.org/2970093002/diff/20001/components/variations/s...
File components/variations/study_filtering_unittest.cc (right):

https://codereview.chromium.org/2970093002/diff/20001/components/variations/s...
components/variations/study_filtering_unittest.cc:261: // Check that if the
filter is not set, study applies to either low end.
On 2017/07/06 17:49:49, rkaplow wrote:
> nit - "either low end setting"? Current wording seems awkward

Done.

[Alexei Svitkine (slow), 2017-07-11 15:08:19]

The CQ bit was checked by asvitkine@chromium.org

[Alexei Svitkine (slow), 2017-07-11 15:08:20]

The patchset sent to the CQ was uploaded after l-g-t-m from
rkaplow@chromium.org, mariakhomenko@chromium.org
Link to the patchset: https://codereview.chromium.org/2970093002/#ps40001
(title: "Address comments.")

[commit-bot: I haz the power, 2017-07-11 15:08:33]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-11 16:47:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-11 16:47:25]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Alexei Svitkine (slow), 2017-07-11 16:59:24]

The CQ bit was checked by asvitkine@chromium.org

[commit-bot: I haz the power, 2017-07-11 16:59:41]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-11 18:43:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-11 18:43:02]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Alexei Svitkine (slow), 2017-07-11 18:48:42]

The CQ bit was checked by asvitkine@chromium.org

[commit-bot: I haz the power, 2017-07-11 18:49:03]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-11 22:35:57]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1499798922631620,
"parent_rev": "a135bf808de1da0ae1198d63b0f1901e42596c4f", "commit_rev":
"bc0b3b5c06bb5fbe1899caaa3fe40d3b0a8b346c"}

[commit-bot: I haz the power, 2017-07-11 22:36:31]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1499798922631620,
"parent_rev": "a8ab1a3bf830a96afb98a655f1b7e991dd2f88e5", "commit_rev":
"a91d3fbb37384c053ac2d092534b42e048661fb8"}

[commit-bot: I haz the power, 2017-07-11 22:36:47]

Description was changed from

==========
Add variations filtering for is_low_end_device.

This will allow studies to target low end devices only.

BUG=738153
==========

to

==========
Add variations filtering for is_low_end_device.

This will allow studies to target low end devices only.

BUG=738153

Review-Url: https://codereview.chromium.org/2970093002
Cr-Commit-Position: refs/heads/master@{#485713}
Committed:
https://chromium.googlesource.com/chromium/src/+/a91d3fbb37384c053ac2d092534b...
==========

[commit-bot: I haz the power, 2017-07-11 22:36:49]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/a91d3fbb37384c053ac2d092534b...