Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Side by Side Diff: components/variations/client_filterable_state.h

Issue 2970093002: Add variations filtering for is_low_end_device. (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_VARIATIONS_CLIENT_FILTERABLE_STATE_H_ 5 #ifndef COMPONENTS_VARIATIONS_CLIENT_FILTERABLE_STATE_H_
6 #define COMPONENTS_VARIATIONS_CLIENT_FILTERABLE_STATE_H_ 6 #define COMPONENTS_VARIATIONS_CLIENT_FILTERABLE_STATE_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "base/time/time.h" 9 #include "base/time/time.h"
10 #include "base/version.h" 10 #include "base/version.h"
(...skipping 22 matching lines...) Expand all
33 33
34 // The hardware form factor that Chrome is running on. 34 // The hardware form factor that Chrome is running on.
35 Study::FormFactor form_factor; 35 Study::FormFactor form_factor;
36 36
37 // The OS on which Chrome is running. 37 // The OS on which Chrome is running.
38 Study::Platform platform; 38 Study::Platform platform;
39 39
40 // The named hardware configuration that Chrome is running on -- used to 40 // The named hardware configuration that Chrome is running on -- used to
41 // identify models of devices. 41 // identify models of devices.
42 std::string hardware_class; 42 std::string hardware_class;
43 43
rkaplow 2017/07/06 17:49:49 can you link to the definition of this somewhere?
Alexei Svitkine (slow) 2017/07/11 15:08:14 Done. Mentioned base::SysInfo::IsLowEndDevice() w
44 // Whether this is a low-end device. Currently only supported on Android.
45 bool is_low_end_device = false;
46
44 // The country code to use for studies configured with session consistency. 47 // The country code to use for studies configured with session consistency.
45 std::string session_consistency_country; 48 std::string session_consistency_country;
46 49
47 // The country code to use for studies configured with permanent consistency. 50 // The country code to use for studies configured with permanent consistency.
48 std::string permanent_consistency_country; 51 std::string permanent_consistency_country;
49 52
50 private: 53 private:
51 DISALLOW_COPY_AND_ASSIGN(ClientFilterableState); 54 DISALLOW_COPY_AND_ASSIGN(ClientFilterableState);
52 }; 55 };
53 56
54 } // namespace variations 57 } // namespace variations
55 58
56 #endif // COMPONENTS_VARIATIONS_CLIENT_FILTERABLE_STATE_H_ 59 #endif // COMPONENTS_VARIATIONS_CLIENT_FILTERABLE_STATE_H_
OLDNEW
« no previous file with comments | « no previous file | components/variations/proto/study.proto » ('j') | components/variations/study_filtering_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698