Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1562)

Issue 2969743002: Update AX Roles for AX_ROLE_MENU_LIST_POPUP and AX_ROLE_MENU_LIST_OPTION (Closed)

Created:
3 years, 5 months ago by dougt
Modified:
3 years, 5 months ago
Reviewers:
nektarios, dmazzoni, nektar
CC:
aboxhall+watch_chromium.org, aleventhal+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dougt+watch_chromium.org, dtseng+watch_chromium.org, jam, je_julie, nektar+watch_chromium.org, yuzo+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Update AX Roles for AX_ROLE_MENU_LIST_POPUP and AX_ROLE_MENU_LIST_OPTION This CL is based on the work tmoniuszko@opera.com did in CL 2962633004 which found a regression in a changed to ROLE_SYSTEM_LIST (see https://codereview.chromium.org/2909853002). BUG=703369 Review-Url: https://codereview.chromium.org/2969743002 Cr-Commit-Position: refs/heads/master@{#485458} Committed: https://chromium.googlesource.com/chromium/src/+/ce47e57c2d95752a2d78fd080a95f4e635140bcb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M content/test/data/accessibility/event/menulist-collapse-expected-win.txt View 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/event/menulist-focus-expected-win.txt View 1 chunk +1 line, -1 line 0 comments Download
M ui/accessibility/platform/ax_platform_node_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
dougt
3 years, 5 months ago (2017-06-30 20:07:00 UTC) #4
nektarios
lgtm
3 years, 5 months ago (2017-06-30 20:10:31 UTC) #6
dougt
dmazzoni, ptal.
3 years, 5 months ago (2017-06-30 22:00:33 UTC) #10
dmazzoni
lgtm
3 years, 5 months ago (2017-07-06 22:45:03 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2969743002/1
3 years, 5 months ago (2017-07-10 23:04:03 UTC) #13
commit-bot: I haz the power
3 years, 5 months ago (2017-07-11 00:18:37 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ce47e57c2d95752a2d78fd080a95...

Powered by Google App Engine
This is Rietveld 408576698