Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2969643002: Reland - Replace FakeServer's implementation with LoopbackServer invocations. (Closed)

Created:
3 years, 5 months ago by pastarmovj
Modified:
3 years, 5 months ago
Reviewers:
Nicolas Zea
CC:
chromium-reviews, extensions-reviews_chromium.org, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, baxley+watch_chromium.org, noyau+watch_chromium.org, marq+watch_chromium.org, chromium-apps-reviews_chromium.org, huangml+watch_chromium.org, liaoyuke+watch_chromium.org, sync-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland - Replace FakeServer's implementation with LoopbackServer invocations. This makes FakeServer a debugging adapter for LoopbackServer. It mostly forwards calls to the actual implementation in the LoopbackServer but also allows for simulating various exceptional conditions and deeper inspection in the data flow. BUG=651415 TEST=All tests still pass. TBR=baxley@chromium.org Review-Url: https://codereview.chromium.org/2969643002 Cr-Commit-Position: refs/heads/master@{#485261} Committed: https://chromium.googlesource.com/chromium/src/+/b0a0d75dc28c61572f5a0e0b236c3ae5295d12fc

Patch Set 1 : Patched https://codereview.chromium.org/2909173003/ on master. #

Patch Set 2 : I shall not put code that does stuff in DCHECKs ever again! I shall not put... #

Patch Set 3 : Rebased on master. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+375 lines, -1387 lines) Patch
M chrome/browser/sync/test/integration/single_client_bookmarks_sync_test.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/sync/test/integration/single_client_extensions_sync_test.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/test/integration/single_client_user_events_sync_test.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/test/integration/single_client_wallet_sync_test.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M components/sync/BUILD.gn View 1 chunk +0 lines, -10 lines 0 comments Download
M components/sync/engine_impl/loopback_server/loopback_server.h View 1 2 5 chunks +69 lines, -0 lines 0 comments Download
M components/sync/engine_impl/loopback_server/loopback_server.cc View 1 2 9 chunks +118 lines, -17 lines 0 comments Download
M components/sync/engine_impl/loopback_server/loopback_server_entity.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/sync/engine_impl/loopback_server/persistent_permanent_entity.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/engine_impl/loopback_server/persistent_permanent_entity.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/engine_impl/loopback_server/persistent_tombstone_entity.h View 2 chunks +10 lines, -2 lines 0 comments Download
M components/sync/engine_impl/loopback_server/persistent_tombstone_entity.cc View 2 chunks +20 lines, -5 lines 0 comments Download
M components/sync/engine_impl/loopback_server/persistent_unique_client_entity.h View 1 chunk +6 lines, -4 lines 0 comments Download
M components/sync/engine_impl/loopback_server/persistent_unique_client_entity.cc View 3 chunks +27 lines, -10 lines 0 comments Download
M components/sync/test/fake_server/android/fake_server_helper_android.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/test/fake_server/android/fake_server_helper_android.cc View 6 chunks +7 lines, -10 lines 0 comments Download
D components/sync/test/fake_server/bookmark_entity.h View 1 chunk +0 lines, -75 lines 0 comments Download
D components/sync/test/fake_server/bookmark_entity.cc View 1 chunk +0 lines, -119 lines 0 comments Download
M components/sync/test/fake_server/bookmark_entity_builder.h View 2 chunks +9 lines, -9 lines 0 comments Download
M components/sync/test/fake_server/bookmark_entity_builder.cc View 5 chunks +15 lines, -12 lines 0 comments Download
M components/sync/test/fake_server/fake_server.h View 1 2 6 chunks +18 lines, -82 lines 0 comments Download
M components/sync/test/fake_server/fake_server.cc View 1 2 7 chunks +48 lines, -486 lines 0 comments Download
D components/sync/test/fake_server/fake_server_entity.h View 1 chunk +0 lines, -91 lines 0 comments Download
D components/sync/test/fake_server/permanent_entity.h View 1 chunk +0 lines, -63 lines 0 comments Download
D components/sync/test/fake_server/permanent_entity.cc View 1 chunk +0 lines, -105 lines 0 comments Download
D components/sync/test/fake_server/tombstone_entity.h View 1 chunk +0 lines, -41 lines 0 comments Download
D components/sync/test/fake_server/tombstone_entity.cc View 1 chunk +0 lines, -49 lines 0 comments Download
D components/sync/test/fake_server/unique_client_entity.h View 1 chunk +0 lines, -64 lines 0 comments Download
D components/sync/test/fake_server/unique_client_entity.cc View 1 chunk +0 lines, -104 lines 0 comments Download
M ios/chrome/test/app/sync_test_util.mm View 5 chunks +12 lines, -11 lines 0 comments Download

Messages

Total messages: 21 (15 generated)
pastarmovj
Hi this is the reland CL for the FakeServer merger.
3 years, 5 months ago (2017-06-30 12:04:02 UTC) #6
Nicolas Zea
lgtm
3 years, 5 months ago (2017-07-05 18:21:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2969643002/60001
3 years, 5 months ago (2017-07-10 09:55:21 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/254235)
3 years, 5 months ago (2017-07-10 09:58:30 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2969643002/100001
3 years, 5 months ago (2017-07-10 13:01:09 UTC) #18
commit-bot: I haz the power
3 years, 5 months ago (2017-07-10 14:17:17 UTC) #21
Message was sent while issue was closed.
Committed patchset #3 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/b0a0d75dc28c61572f5a0e0b236c...

Powered by Google App Engine
This is Rietveld 408576698