components/sync/engine_impl/loopback_server/persistent_unique_client_entity.h - Issue 2969643002: Reland - Replace FakeServer's implementation with LoopbackServer invocations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync/engine_impl/loopback_server/persistent_unique_client_entity.h

Issue 2969643002: Reland - Replace FakeServer's implementation with LoopbackServer invocations. (Closed)

Patch Set: Rebased on master. Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/sync/engine_impl/loopback_server/persistent_tombstone_entity.cc ('k') | components/sync/engine_impl/loopback_server/persistent_unique_client_entity.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/sync/engine_impl/loopback_server/persistent_unique_client_entity.h

diff --git a/components/sync/engine_impl/loopback_server/persistent_unique_client_entity.h b/components/sync/engine_impl/loopback_server/persistent_unique_client_entity.h

index 8e039002b68d3ab50c04d023bf207753105c5394..746f0bd2307550f9741e4d4d2653194082bb1539 100644

--- a/components/sync/engine_impl/loopback_server/persistent_unique_client_entity.h

+++ b/components/sync/engine_impl/loopback_server/persistent_unique_client_entity.h

@@ -39,12 +39,14 @@ class PersistentUniqueClientEntity : public LoopbackServerEntity {

~PersistentUniqueClientEntity() override;

// Factory function for creating a PersistentUniqueClientEntity.

- static std::unique_ptr<LoopbackServerEntity> Create(

+ static std::unique_ptr<LoopbackServerEntity> CreateFromEntity(

const sync_pb::SyncEntity& client_entity);

- // Derives an ID from a unique client tagged entity.

- static std::string EffectiveIdForClientTaggedEntity(

- const sync_pb::SyncEntity& entity);

+ // Factory function for creating a PersistentUniqueClientEntity for use in the

+ // FakeServer injection API.

+ static std::unique_ptr<LoopbackServerEntity> CreateFromEntitySpecifics(

+ const std::string& name,

+ const sync_pb::EntitySpecifics& entity_specifics);

// LoopbackServerEntity implementation.

bool RequiresParentId() const override;