Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2969603002: Move two BrowserAccessibility role predicates to ax_role_properties. (Closed)

Created:
3 years, 5 months ago by dougt
Modified:
3 years, 5 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, aboxhall+watch_chromium.org, nektar+watch_chromium.org, jam, yuzo+watch_chromium.org, dougt+watch_chromium.org, darin-cc_chromium.org, aleventhal+watch_chromium.org, dtseng+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move two BrowserAccessibility role predicates to ax_role_properties. BUG=703369 Review-Url: https://codereview.chromium.org/2969603002 Cr-Commit-Position: refs/heads/master@{#485462} Committed: https://chromium.googlesource.com/chromium/src/+/37f7a151bff77deda03cc942b7e7abde9ab5f549

Patch Set 1 #

Patch Set 2 : Androids #

Patch Set 3 : macos #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -57 lines) Patch
M content/browser/accessibility/browser_accessibility.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/accessibility/browser_accessibility.cc View 1 chunk +0 lines, -49 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_android.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/accessibility/browser_accessibility_cocoa.mm View 1 2 3 chunks +3 lines, -4 lines 0 comments Download
M content/browser/accessibility/one_shot_accessibility_tree_search.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/accessibility/ax_role_properties.h View 1 chunk +6 lines, -0 lines 0 comments Download
M ui/accessibility/ax_role_properties.cc View 1 chunk +49 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
dougt
3 years, 5 months ago (2017-06-30 18:41:12 UTC) #10
dmazzoni
lgtm
3 years, 5 months ago (2017-07-06 22:44:34 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2969603002/40001
3 years, 5 months ago (2017-07-10 23:03:49 UTC) #14
commit-bot: I haz the power
3 years, 5 months ago (2017-07-11 00:22:15 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/37f7a151bff77deda03cc942b7e7...

Powered by Google App Engine
This is Rietveld 408576698