content/browser/accessibility/browser_accessibility_android.cc - Issue 2969603002: Move two BrowserAccessibility role predicates to ax_role_properties.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/browser_accessibility_android.cc

Issue 2969603002: Move two BrowserAccessibility role predicates to ax_role_properties. (Closed)

Patch Set: macos Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/accessibility/browser_accessibility_android.cc

diff --git a/content/browser/accessibility/browser_accessibility_android.cc b/content/browser/accessibility/browser_accessibility_android.cc

index 4e9d9362bf7b207bac410cef8891da7b09c17297..069cc639d7a3ce7b3309357eaea5ab3980054658 100644

--- a/content/browser/accessibility/browser_accessibility_android.cc

+++ b/content/browser/accessibility/browser_accessibility_android.cc

@@ -292,7 +292,7 @@ bool BrowserAccessibilityAndroid::IsInterestingOnAndroid() const {

return true;

// If it's not focusable but has a control role, then it's interesting.

- if (IsControl())

+ if (ui::IsControl(GetRole()))

return true;

// Otherwise, the interesting nodes are leaf nodes with non-whitespace text.