Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(691)

Issue 2969483002: Revert of Ash: Inline InitKeyboard, and make the caller of it call CreateKeyboard. (Closed)

Created:
3 years, 5 months ago by oka
Modified:
3 years, 5 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

Revert of Ash: Inline InitKeyboard, and make the caller of it call CreateKeyboard. (patchset #1 id:1 of https://codereview.chromium.org/2964083002/ ) Reason for revert: I resolved a merge conflict in a wrong way, and it wouldn't compile. Original issue's description: > Ash: Inline InitKeyboard, and make the caller of it call CreateKeyboard. > > InitKeyboard creates a keyboard controller but doesn't associate it with any > root window controller. It's potentially problematic if > keyboard::ShowKeyboard is called before RootWindowController::ActivateKeyboard. > > Bug: 712873 > > Change-Id: I5b34cd6f8b9e1b0736b5d91880e3aedc9d57970c > Reviewed-on: https://chromium-review.googlesource.com/535221 > Reviewed-by: Mitsuru Oshima <oshima@chromium.org>; > Commit-Queue: Keigo Oka <oka@chromium.org>; > Cr-Original-Commit-Position: refs/heads/master@{#480313} > Review-Url: https://codereview.chromium.org/2964083002 . > Cr-Commit-Position: refs/branch-heads/3112@{#492} > Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} > Committed: https://chromium.googlesource.com/chromium/src/+/9d3867c09566a7e9f3eae92524db0237c14b0c94 TBR= # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2969483002 Cr-Commit-Position: refs/branch-heads/3112@{#493} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/366c34997d1699cb386ff852d6d333f10f141299

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -19 lines) Patch
M ash/root_window_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shell.h View 2 chunks +5 lines, -2 lines 0 comments Download
M ash/shell.cc View 1 chunk +1 line, -16 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
oka
Created Revert of Ash: Inline InitKeyboard, and make the caller of it call CreateKeyboard.
3 years, 5 months ago (2017-06-29 19:00:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2969483002/1
3 years, 5 months ago (2017-06-29 19:00:43 UTC) #3
commit-bot: I haz the power
3 years, 5 months ago (2017-06-29 19:01:27 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/366c34997d1699cb386ff852d6d3...

Powered by Google App Engine
This is Rietveld 408576698