Ash: Inline InitKeyboard, and make the caller of it call CreateKeyboard.

Ash: Inline InitKeyboard, and make the caller of it call CreateKeyboard.

InitKeyboard creates a keyboard controller but doesn't associate it with any
root window controller. It's potentially problematic if
keyboard::ShowKeyboard is called before RootWindowController::ActivateKeyboard.

Bug: 712873

Change-Id: I5b34cd6f8b9e1b0736b5d91880e3aedc9d57970c
Reviewed-on: https://chromium-review.googlesource.com/535221
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>;
Commit-Queue: Keigo Oka <oka@chromium.org>;
Cr-Original-Commit-Position: refs/heads/master@{#480313}
Review-Url: https://codereview.chromium.org/2964083002 .
Cr-Commit-Position: refs/branch-heads/3112@{#492}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}
Committed: https://chromium.googlesource.com/chromium/src/+/9d3867c09566a7e9f3eae92524db0237c14b0c94

[oka, 2017-06-29 18:45:22]

Description was changed from

==========
Ash: Inline InitKeyboard, and make the caller of it call CreateKeyboard.

InitKeyboard creates a keyboard controller but doesn't associate it with any
root window controller. It's potentially problematic if
keyboard::ShowKeyboard is called before RootWindowController::ActivateKeyboard.

Bug: 712873

Change-Id: I5b34cd6f8b9e1b0736b5d91880e3aedc9d57970c
Reviewed-on: https://chromium-review.googlesource.com/535221
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Keigo Oka <oka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480313}
(cherry picked from commit e82281ac05b7c0571c8f3c603487f74b686547f9)
==========

to

==========
Ash: Inline InitKeyboard, and make the caller of it call CreateKeyboard.

InitKeyboard creates a keyboard controller but doesn't associate it with any
root window controller. It's potentially problematic if
keyboard::ShowKeyboard is called before RootWindowController::ActivateKeyboard.

Bug: 712873

Change-Id: I5b34cd6f8b9e1b0736b5d91880e3aedc9d57970c
Reviewed-on: https://chromium-review.googlesource.com/535221
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Keigo Oka <oka@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#480313}
Review-Url: https://codereview.chromium.org/2964083002 .
Cr-Commit-Position: refs/branch-heads/3112@{#492}
Cr-Branched-From:
b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}
Committed:
https://chromium.googlesource.com/chromium/src/+/9d3867c09566a7e9f3eae92524db...
==========

[oka, 2017-06-29 18:45:24]

Committed patchset #1 (id:1) manually as
9d3867c09566a7e9f3eae92524db0237c14b0c94.

[oka, 2017-06-29 19:00:17]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2969483002/ by oka@chromium.org.

The reason for reverting is: I resolved a merge conflict in a wrong way, and it
wouldn't compile..