Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(726)

Issue 2969463003: Move resource_request.h to content/public/common. (Closed)

Created:
3 years, 5 months ago by mmenke
Modified:
3 years, 5 months ago
Reviewers:
kenrb, jam
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, serviceworker-reviews, mlamouri+watch-content_chromium.org, shimazu+serviceworker_chromium.org, asanka, rdsmith+watch_chromium.org, jam, kinuko+serviceworker, nhiroki, kinuko, blink-worker-reviews_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, loading-reviews_chromium.org, horo+watch_chromium.org, kinuko+watch, tzik, scheduler-bugs_chromium.org, pfeldman, horo
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move resource_request.h to content/public/common. It's used by the network service's API, but was in content/common. For chrome/ to be able to use the network service directly, the API must be in content/public/common. Eventually, it will be moved outside of content. This also requires splitting service_worker_types.h, so that types ResourceRequest depends on are also in content/public/common. Eventually these will need to be removed from the NetworkService's API. BUG=736906 Review-Url: https://codereview.chromium.org/2969463003 Cr-Commit-Position: refs/heads/master@{#484320} Committed: https://chromium.googlesource.com/chromium/src/+/5a4902c07448f1636f48ace6337fcda5891d5d3f

Patch Set 1 #

Patch Set 2 : +Black Magic #

Total comments: 1

Patch Set 3 : Merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -299 lines) Patch
M content/browser/appcache/appcache_subresource_url_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/appcache/appcache_url_loader_job.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/appcache/appcache_url_loader_request.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/devtools/protocol/network_handler.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
M content/browser/loader/DEPS View 5 chunks +4 lines, -4 lines 0 comments Download
M content/browser/loader/async_resource_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/resource_dispatcher_host_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/browser/loader/resource_dispatcher_host_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/browser/loader/url_loader_factory_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/url_loader_factory_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/security_exploit_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/browser/service_worker/foreign_fetch_request_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/foreign_fetch_request_handler.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/browser/service_worker/service_worker_controllee_request_handler.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_controllee_request_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/service_worker/service_worker_controllee_request_handler_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_database.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/service_worker/service_worker_handle.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_metrics.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_metrics.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/service_worker/service_worker_navigation_handle.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_provider_host.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_registration_handle.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_request_handler.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_request_handler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_url_request_job.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_url_request_job_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/child/request_extra_data.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/child/resource_dispatcher.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/child/resource_dispatcher_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/child/url_response_body_consumer_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/child/web_url_loader_impl.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M content/child/web_url_request_util.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/BUILD.gn View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M content/common/navigation_params.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/resource_messages.h View 1 chunk +2 lines, -2 lines 0 comments Download
D content/common/resource_request.h View 1 chunk +0 lines, -203 lines 0 comments Download
D content/common/resource_request.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M content/common/service_worker/service_worker_fetch_request.typemap View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/common/service_worker/service_worker_types.h View 3 chunks +1 line, -42 lines 0 comments Download
M content/common/service_worker/service_worker_types.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/common/service_worker/service_worker_utils.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/url_request.typemap View 1 chunk +1 line, -1 line 0 comments Download
M content/network/DEPS View 2 chunks +1 line, -1 line 0 comments Download
M content/network/network_service_url_loader_factory_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/common/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
A + content/public/common/resource_request.h View 3 chunks +4 lines, -5 lines 0 comments Download
A + content/public/common/resource_request.cc View 1 chunk +1 line, -1 line 0 comments Download
A content/public/common/service_worker_modes.h View 1 chunk +56 lines, -0 lines 0 comments Download
M content/renderer/scheduler/resource_dispatch_throttler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/service_worker/service_worker_context_client.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/service_worker/worker_fetch_context_impl.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 29 (20 generated)
mmenke
[jam]: PTAL. Only changes that aren't just modifying includes and moving files is the splitting ...
3 years, 5 months ago (2017-06-30 14:47:11 UTC) #11
jam
lgtm
3 years, 5 months ago (2017-06-30 15:15:46 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2969463003/20001
3 years, 5 months ago (2017-07-05 15:33:32 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/251374)
3 years, 5 months ago (2017-07-05 15:37:02 UTC) #16
mmenke
[+kenrb]: Please review content\common\resource_messages.h, content\common\service_worker\service_worker_fetch_request.typemap, and content\common\url_request.typemap I've only moving some stuff from content/common to ...
3 years, 5 months ago (2017-07-05 16:27:56 UTC) #18
kenrb
ipc lgtm
3 years, 5 months ago (2017-07-05 16:32:24 UTC) #21
mmenke
On 2017/07/05 16:32:24, kenrb wrote: > ipc lgtm Thanks! (And thanks to jam as well)
3 years, 5 months ago (2017-07-05 16:35:03 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2969463003/40001
3 years, 5 months ago (2017-07-05 16:42:24 UTC) #26
commit-bot: I haz the power
3 years, 5 months ago (2017-07-05 18:50:44 UTC) #29
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/5a4902c07448f1636f48ace6337f...

Powered by Google App Engine
This is Rietveld 408576698