Move NetworkService mojom files to content/public/common.

Move NetworkService mojom files to content/public/common.

This will allow chrome/ code to use the NetworkService's API, both to
configure the NetworkService and to issue requests.

Also moves some associated tyemaps and class files over.

BUG=736906
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2964503003
Cr-Commit-Position: refs/heads/master@{#484325}
Committed: https://chromium.googlesource.com/chromium/src/+/680c214abd32a744f4d929759866a037a6915d2f

[mmenke, 2017-06-30 16:19:46]

Description was changed from

==========
Move NetworkService mojom files to content/public/common.

This will allow chrome/ code to use the NetworkService's API, both to
configure the NetworkService and to issue requests.

Also moves some associated tyemaps and class files over.

BUG=736906
==========

to

==========
Move NetworkService mojom files to content/public/common.

This will allow chrome/ code to use the NetworkService's API, both to
configure the NetworkService and to issue requests.

Also moves some associated tyemaps and class files over.

BUG=736906
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[mmenke, 2017-06-30 16:20:00]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-30 16:20:16]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mmenke, 2017-06-30 16:25:27]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-30 16:25:44]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-30 16:31:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-30 16:31:18]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[mmenke, 2017-06-30 19:58:29]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-30 19:58:58]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-30 20:27:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-30 20:27:30]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[mmenke, 2017-06-30 23:04:55]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-30 23:05:29]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mmenke, 2017-07-01 01:02:59]

mmenke@chromium.org changed reviewers:
+ jam@chromium.org

[mmenke, 2017-07-01 01:03:01]

No source files changed, other than include paths and header guards.

https://codereview.chromium.org/2964503003/diff/60001/content/public/common/B...
File content/public/common/BUILD.gn (right):

https://codereview.chromium.org/2964503003/diff/60001/content/public/common/B...
content/public/common/BUILD.gn:348: # Must depend on //content/public/common/
instead, to maintain component build.
Git CL format didn't catch this. :(  I'll fix on Monday.

[commit-bot: I haz the power, 2017-07-01 01:42:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-01 01:42:58]

Dry run: This issue passed the CQ dry run.

[jam, 2017-07-05 15:37:14]

lgtm

[mmenke, 2017-07-05 16:34:18]

mmenke@chromium.org changed reviewers:
+ kenrb@chromium.org

[mmenke, 2017-07-05 16:34:19]

[+kenrb]:  Please review *.mojom, *.typemap, *_struct_trats.h,
content/common/resource_messages.h.

All this CL does is move stuff around, and add CONTENT_EXPORT to the mojom files
for the NetworkService.  No source files are modified, beyond includes.

[kenrb, 2017-07-05 16:47:53]

ipc/mojom lgtm

[mmenke, 2017-07-05 17:02:09]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-05 17:02:23]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mmenke, 2017-07-05 18:51:58]

The CQ bit was unchecked by mmenke@chromium.org

[mmenke, 2017-07-05 18:52:09]

The CQ bit was checked by mmenke@chromium.org

[mmenke, 2017-07-05 18:52:11]

The patchset sent to the CQ was uploaded after l-g-t-m from jam@chromium.org
Link to the patchset: https://codereview.chromium.org/2964503003/#ps80001
(title: "Merge")

[commit-bot: I haz the power, 2017-07-05 18:52:45]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-05 19:08:59]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1499280729782560,
"parent_rev": "9bd16d04a28349748da422fa7361c1832c3cd04e", "commit_rev":
"680c214abd32a744f4d929759866a037a6915d2f"}

[commit-bot: I haz the power, 2017-07-05 19:09:15]

Description was changed from

==========
Move NetworkService mojom files to content/public/common.

This will allow chrome/ code to use the NetworkService's API, both to
configure the NetworkService and to issue requests.

Also moves some associated tyemaps and class files over.

BUG=736906
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Move NetworkService mojom files to content/public/common.

This will allow chrome/ code to use the NetworkService's API, both to
configure the NetworkService and to issue requests.

Also moves some associated tyemaps and class files over.

BUG=736906
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2964503003
Cr-Commit-Position: refs/heads/master@{#484325}
Committed:
https://chromium.googlesource.com/chromium/src/+/680c214abd32a744f4d929759866...
==========

[commit-bot: I haz the power, 2017-07-05 19:09:17]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/680c214abd32a744f4d929759866...

[Nico, 2017-08-16 20:54:38]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2017-08-16 20:54:40]

https://codereview.chromium.org/2964503003/diff/80001/content/public/common/B...
File content/public/common/BUILD.gn (right):

https://codereview.chromium.org/2964503003/diff/80001/content/public/common/B...
content/public/common/BUILD.gn:347: mojom("interfaces") {
Doesn't this now need a public_dep on ui/accessibility? That's what depends on
ax_gen which generates ui/accessibility/ax_enums.h, which is used while this
target is built:

FAILED: obj/content/public/common/interfaces/url_loader_factory.mojom.obj 
../../third_party/llvm-build/Release+Asserts/bin/clang-cl --rsp-quoting=posix
/nologo /showIncludes 
@obj/content/public/common/interfaces/url_loader_factory.mojom.obj.rsp /c
gen/content/public/common/url_loader_factory.mojom.cc
/Foobj/content/public/common/interfaces/url_loader_factory.mojom.obj
/Fd"obj/content/public/common/interfaces_cc.pdb"
In file included from gen/content/public/common/url_loader_factory.mojom.cc:29:
In file included from ../../content/common/resource_messages.h:17:
In file included from ../../content/public/common/common_param_traits.h:24:
In file included from
../../content/public/common/common_param_traits_macros.h:28:
../../ui/accessibility/ax_node_data.h(17,10):  fatal error:
'ui/accessibility/ax_enums.h' file not found
#include "ui/accessibility/ax_enums.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~

(Or maybe that dependency is missing elsewhere in content?)

[Nico, 2017-08-16 21:02:44]

(sorry for the noise)

https://codereview.chromium.org/2964503003/diff/80001/content/public/common/B...
File content/public/common/BUILD.gn (right):

https://codereview.chromium.org/2964503003/diff/80001/content/public/common/B...
content/public/common/BUILD.gn:347: mojom("interfaces") {
After some more digging, I think this flake is unrelated to your change;
https://chromium-review.googlesource.com/617768 might fix it.